Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
libtime:
strftime
and strptime
return type changed to `Result<Str…
…ing, ParseError>`. `strftime` currently returns a `String`. This does not indicate that this function may return an error due to to a malformed format string. This change introduces a `ParseError` enum which indicates the type of error that occurred. The return type of `strptime` was also changed to use this new enum instead of returning `Result<String, String>`. Now, all instances where `strftime` was used need to have their return value checked to see if it were valid or not. [breaking-change]
- Loading branch information
84ce372
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from alexcrichton
at hatahet@84ce372
84ce372
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging hatahet/rust/mybranch = 84ce372c into auto
84ce372
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hatahet/rust/mybranch = 84ce372c merged ok, testing candidate = 88739d75
84ce372
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/1759
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/1756
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/1750
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/1756
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/1753
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/1750
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/1749
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/1752
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/1407
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/1409
exception: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/246
84ce372
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from alexcrichton
at hatahet@84ce372
84ce372
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging hatahet/rust/mybranch = 84ce372c into auto
84ce372
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hatahet/rust/mybranch = 84ce372c merged ok, testing candidate = ff61b74
84ce372
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/1762
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/1759
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/1753
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/1759
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/1756
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/1755
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/1755
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/1759
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/1753
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/1752
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/1755
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/1411
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/1410
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/1412
success: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/249
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/250
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-c/builds/242
84ce372
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = ff61b74