Comment change suggestions from oli-obk's code review

Co-authored-by: Oli Scherer <[email protected]>
rust-lang · Jan 16, 2024 · 61faffb · 61faffb
1 parent ba5dcc7
commit 61faffb
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/compiler/rustc_codegen_cranelift/src/intrinsics/mod.rs b/compiler/rustc_codegen_cranelift/src/intrinsics/mod.rs
@@ -442,7 +442,7 @@ fn codegen_regular_intrinsic_call<'tcx>(
         sym::is_val_statically_known => {
             intrinsic_args!(fx, args => (_a); intrinsic);
 
-            // FIXME impliment intrinsic or guarantee propogation of false
+            // FIXME actually return `true` in case the argument is a constant
             let res = fx.bcx.ins().iconst(cranelift_codegen::ir::types::I8, false as i64);
             ret.write_cvalue(fx, CValue::by_val(res, ret.layout()));
         }

diff --git a/tests/codegen/is_val_statically_known.rs b/tests/codegen/is_val_statically_known.rs
@@ -1,5 +1,3 @@
-// #[cfg(bootstrap)]
-// ignore-stage1
 // compile-flags: --crate-type=lib -Zmerge-functions=disabled
 
 #![feature(core_intrinsics)]