Use .extend(..) instead of push()-ing in loop

A bit less readable but more compact, and maybe faster? We'll see.
rust-lang · Apr 13, 2022 · 5f2c6b9 · 5f2c6b9
1 parent 2b14529
commit 5f2c6b9
Showing 1 changed file with 12 additions and 18 deletions.
diff --git a/compiler/rustc_span/src/lib.rs b/compiler/rustc_span/src/lib.rs
@@ -1319,24 +1319,18 @@ impl<D: Decoder> Decodable<D> for SourceFile {
                 lines.push(line_start);
 
                 match bytes_per_diff {
-                    1 => {
-                        for _ in 1..num_lines {
-                            line_start = line_start + BytePos(d.read_u8() as u32);
-                            lines.push(line_start);
-                        }
-                    }
-                    2 => {
-                        for _ in 1..num_lines {
-                            line_start = line_start + BytePos(d.read_u16() as u32);
-                            lines.push(line_start);
-                        }
-                    }
-                    4 => {
-                        for _ in 1..num_lines {
-                            line_start = line_start + BytePos(d.read_u32());
-                            lines.push(line_start);
-                        }
-                    }
+                    1 => lines.extend((1..num_lines).map(|_| {
+                        line_start = line_start + BytePos(d.read_u8() as u32);
+                        line_start
+                    })),
+                    2 => lines.extend((1..num_lines).map(|_| {
+                        line_start = line_start + BytePos(d.read_u16() as u32);
+                        line_start
+                    })),
+                    4 => lines.extend((1..num_lines).map(|_| {
+                        line_start = line_start + BytePos(d.read_u32());
+                        line_start
+                    })),
                     _ => unreachable!(),
                 }
             }