Skip to content

Commit

Permalink
NVPTX: Enable previously disabled tests
Browse files Browse the repository at this point in the history
  • Loading branch information
Kjetil Kjeka committed Oct 31, 2023
1 parent 10e5530 commit 5a9b1dc
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 13 deletions.
3 changes: 1 addition & 2 deletions src/bootstrap/src/core/build_steps/tool.rs
Original file line number Diff line number Diff line change
Expand Up @@ -803,8 +803,7 @@ tool_extended!((self, builder),
Rls, "src/tools/rls", "rls", stable=true, tool_std=true;
RustDemangler, "src/tools/rust-demangler", "rust-demangler", stable=false, tool_std=true;
Rustfmt, "src/tools/rustfmt", "rustfmt", stable=true, add_bins_to_sysroot = ["rustfmt", "cargo-fmt"];
EmbeddedLinker, "src/tools/embedded-linker", "rust-embedded-linker", stable=false, add_bins_to_sysroot = ["rust-embedded-linker"];
PtxLinker, "src/tools/embedded-linker", "rust-ptx-linker", stable=false, add_bins_to_sysroot = ["rust-ptx-linker"];
EmbeddedLinker, "src/tools/embedded-linker", "rust-embedded-linker", stable=true, add_bins_to_sysroot = ["rust-embedded-linker"];
);

impl<'a> Builder<'a> {
Expand Down
1 change: 0 additions & 1 deletion tests/assembly/nvptx-arch-default.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
// assembly-output: ptx-linker
// compile-flags: --crate-type cdylib
// only-nvptx64
// ignore-nvptx64

#![no_std]

Expand Down
1 change: 0 additions & 1 deletion tests/assembly/nvptx-arch-emit-asm.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
// assembly-output: emit-asm
// compile-flags: --crate-type rlib
// only-nvptx64
// ignore-nvptx64

#![no_std]

Expand Down
1 change: 0 additions & 1 deletion tests/assembly/nvptx-arch-target-cpu.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
// assembly-output: ptx-linker
// compile-flags: --crate-type cdylib -C target-cpu=sm_50
// only-nvptx64
// ignore-nvptx64

#![no_std]

Expand Down
1 change: 0 additions & 1 deletion tests/assembly/nvptx-internalizing.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
// assembly-output: ptx-linker
// compile-flags: --crate-type cdylib
// only-nvptx64
// ignore-nvptx64

#![feature(abi_ptx)]
#![no_std]
Expand Down
10 changes: 5 additions & 5 deletions tests/assembly/nvptx-kernel-abi/nvptx-kernel-args-abi-v7.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
// assembly-output: ptx-linker
// compile-flags: --crate-type cdylib -C target-cpu=sm_86
// only-nvptx64
// ignore-nvptx64

// The following ABI tests are made with nvcc 11.6 does.
//
Expand Down Expand Up @@ -226,10 +225,11 @@ pub unsafe extern "ptx-kernel" fn f_byte_array_arg(_a: [u8; 5]) {}
#[no_mangle]
pub unsafe extern "ptx-kernel" fn f_float_array_arg(_a: [f32; 5]) {}

// CHECK: .visible .entry f_u128_array_arg(
// CHECK: .param .align 16 .b8 f_u128_array_arg_param_0[80]
#[no_mangle]
pub unsafe extern "ptx-kernel" fn f_u128_array_arg(_a: [u128; 5]) {}
// FIXME: u128 started to break compilation with disabled CI
// NO_CHECK: .visible .entry f_u128_array_arg(
// NO_CHECK: .param .align 16 .b8 f_u128_array_arg_param_0[80]
//#[no_mangle]
//pub unsafe extern "ptx-kernel" fn f_u128_array_arg(_a: [u128; 5]) {}

// CHECK: .visible .entry f_u32_slice_arg(
// CHECK: .param .u64 f_u32_slice_arg_param_0
Expand Down
3 changes: 1 addition & 2 deletions tests/assembly/nvptx-safe-naming.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
// assembly-output: ptx-linker
// compile-flags: --crate-type cdylib
// only-nvptx64
// ignore-nvptx64

#![feature(abi_ptx)]
#![no_std]
Expand All @@ -10,7 +9,7 @@
extern crate breakpoint_panic_handler;

// Verify function name doesn't contain unacceaptable characters.
// CHECK: .func (.param .b32 func_retval0) [[IMPL_FN:[a-zA-Z0-9$_]+square[a-zA-Z0-9$_]+]](
// CHECK: .func (.param .b32 func_retval0) [[IMPL_FN:[a-zA-Z0-9$_]+square[a-zA-Z0-9$_]+]]

// CHECK-LABEL: .visible .entry top_kernel(
#[no_mangle]
Expand Down

0 comments on commit 5a9b1dc

Please sign in to comment.