Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
native: Remove a bogus assert in net::read
This assert was likely inherited from some point, but it's not quite valid as a no-timeout read may enter this loop, but data could be stolen by any other read after the socket is deemed readable. I saw this fail in a recent bors run where the assertion was tripped.
- Loading branch information
2ec7bb8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from brson
at alexcrichton@2ec7bb8
2ec7bb8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging alexcrichton/rust/remove-net-assert = 2ec7bb8 into auto
2ec7bb8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alexcrichton/rust/remove-net-assert = 2ec7bb8 merged ok, testing candidate = 0a16402d
2ec7bb8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
failure: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/1133
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/1135
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/1135
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/1134
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/1135
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/1130
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/1131
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/1130
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/1136
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/1131
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/1130
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/1133
exception: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/1134
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/1132
2ec7bb8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from brson
at alexcrichton@2ec7bb8
2ec7bb8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging alexcrichton/rust/remove-net-assert = 2ec7bb8 into auto
2ec7bb8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alexcrichton/rust/remove-net-assert = 2ec7bb8 merged ok, testing candidate = 59936909
2ec7bb8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/1190
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/1189
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/1189
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/1190
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/1183
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/1183
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/1183
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/1188
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/1183
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/1183
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/1186
exception: http://buildbot.rust-lang.org/builders/auto-win32-32-opt/builds/20
2ec7bb8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from brson
at alexcrichton@2ec7bb8
2ec7bb8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging alexcrichton/rust/remove-net-assert = 2ec7bb8 into auto
2ec7bb8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alexcrichton/rust/remove-net-assert = 2ec7bb8 merged ok, testing candidate = aaf141d
2ec7bb8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/1236
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/1235
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/1235
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/1236
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/1229
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/1229
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/1229
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/1234
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/1229
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/1229
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/1232
success: http://buildbot.rust-lang.org/builders/auto-win32-32-opt/builds/66
success: http://buildbot.rust-lang.org/builders/auto-win32-32-nopt-t/builds/66
success: http://buildbot.rust-lang.org/builders/auto-win32-32-nopt-c/builds/66
2ec7bb8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = aaf141d