-
Notifications
You must be signed in to change notification settings - Fork 12.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Avoid O(n^2) performance by reconsidering the full set of obligations…
… only when we are about to report an error (#18208). I found it is still important to consider the full set in order to make tests like `let x: Vec<_> = obligations.iter().collect()` work.
- Loading branch information
1 parent
faed648
commit 1da73ff
Showing
4 changed files
with
128 additions
and
41 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1da73ff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from pnkfelix
at nikomatsakis@1da73ff
1da73ff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging nikomatsakis/rust/issue-18208 = 1da73ff into auto
1da73ff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nikomatsakis/rust/issue-18208 = 1da73ff merged ok, testing candidate = 58dc0a0
1da73ff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/1987
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/1986
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/1979
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/1986
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/1981
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/1980
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/1980
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/1984
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/1977
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/1977
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/1980
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/1636
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/1630
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/1638
success: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/476
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/471
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-c/builds/464
1da73ff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 58dc0a0