Skip to content

Commit

Permalink
Replace Freeze bounds with Share bounds
Browse files Browse the repository at this point in the history
  • Loading branch information
flaper87 committed Mar 20, 2014
1 parent 21d23ff commit 12ecafb
Show file tree
Hide file tree
Showing 18 changed files with 63 additions and 54 deletions.
28 changes: 17 additions & 11 deletions src/libsync/arc.rs
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,9 @@ use std::kinds::marker;
use std::sync::arc::UnsafeArc;
use std::task;

#[cfg(stage0)]
use std::kinds::Share;

/// As sync::condvar, a mechanism for unlock-and-descheduling and
/// signaling, for use with the Arc types.
pub struct ArcCondvar<'a> {
Expand Down Expand Up @@ -122,7 +125,7 @@ pub struct Arc<T> { priv x: UnsafeArc<T> }
* Access the underlying data in an atomically reference counted
* wrapper.
*/
impl<T:Freeze+Send> Arc<T> {
impl<T: Share + Send> Arc<T> {
/// Create an atomically reference counted wrapper.
#[inline]
pub fn new(data: T) -> Arc<T> {
Expand All @@ -135,7 +138,7 @@ impl<T:Freeze+Send> Arc<T> {
}
}

impl<T:Freeze + Send> Clone for Arc<T> {
impl<T: Share + Send> Clone for Arc<T> {
/**
* Duplicate an atomically reference counted wrapper.
*
Expand Down Expand Up @@ -295,19 +298,21 @@ struct RWArcInner<T> { lock: RWLock, failed: bool, data: T }
pub struct RWArc<T> {
priv x: UnsafeArc<RWArcInner<T>>,
priv marker: marker::NoFreeze,
priv marker1: marker::NoShare,
}

impl<T:Freeze + Send> Clone for RWArc<T> {
impl<T: Share + Send> Clone for RWArc<T> {
/// Duplicate a rwlock-protected Arc. See arc::clone for more details.
#[inline]
fn clone(&self) -> RWArc<T> {
RWArc { x: self.x.clone(),
marker: marker::NoFreeze, }
marker: marker::NoFreeze,
marker1: marker::NoShare, }
}

}

impl<T:Freeze + Send> RWArc<T> {
impl<T: Share + Send> RWArc<T> {
/// Create a reader/writer Arc with the supplied data.
pub fn new(user_data: T) -> RWArc<T> {
RWArc::new_with_condvars(user_data, 1)
Expand All @@ -323,7 +328,8 @@ impl<T:Freeze + Send> RWArc<T> {
failed: false, data: user_data
};
RWArc { x: UnsafeArc::new(data),
marker: marker::NoFreeze, }
marker: marker::NoFreeze,
marker1: marker::NoShare, }
}

/**
Expand Down Expand Up @@ -454,7 +460,7 @@ impl<T:Freeze + Send> RWArc<T> {
// lock it. This wraps the unsafety, with the justification that the 'lock'
// field is never overwritten; only 'failed' and 'data'.
#[doc(hidden)]
fn borrow_rwlock<T:Freeze + Send>(state: *mut RWArcInner<T>) -> *RWLock {
fn borrow_rwlock<T: Share + Send>(state: *mut RWArcInner<T>) -> *RWLock {
unsafe { cast::transmute(&(*state).lock) }
}

Expand All @@ -471,7 +477,7 @@ pub struct RWReadMode<'a, T> {
priv token: sync::RWLockReadMode<'a>,
}

impl<'a, T:Freeze + Send> RWWriteMode<'a, T> {
impl<'a, T: Share + Send> RWWriteMode<'a, T> {
/// Access the pre-downgrade RWArc in write mode.
pub fn write<U>(&mut self, blk: |x: &mut T| -> U) -> U {
match *self {
Expand Down Expand Up @@ -510,7 +516,7 @@ impl<'a, T:Freeze + Send> RWWriteMode<'a, T> {
}
}

impl<'a, T:Freeze + Send> RWReadMode<'a, T> {
impl<'a, T: Share + Send> RWReadMode<'a, T> {
/// Access the post-downgrade rwlock in read mode.
pub fn read<U>(&self, blk: |x: &T| -> U) -> U {
match *self {
Expand All @@ -534,7 +540,7 @@ pub struct CowArc<T> { priv x: UnsafeArc<T> }
/// mutation of the contents if there is only a single reference to
/// the data. If there are multiple references the data is automatically
/// cloned and the task modifies the cloned data in place of the shared data.
impl<T:Clone+Send+Freeze> CowArc<T> {
impl<T: Clone + Send + Share> CowArc<T> {
/// Create a copy-on-write atomically reference counted wrapper
#[inline]
pub fn new(data: T) -> CowArc<T> {
Expand All @@ -558,7 +564,7 @@ impl<T:Clone+Send+Freeze> CowArc<T> {
}
}

impl<T:Clone+Send+Freeze> Clone for CowArc<T> {
impl<T: Clone + Send + Share> Clone for CowArc<T> {
/// Duplicate a Copy-on-write Arc. See arc::clone for more details.
fn clone(&self) -> CowArc<T> {
CowArc { x: self.x.clone() }
Expand Down
8 changes: 4 additions & 4 deletions src/libsyntax/ast.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1159,12 +1159,12 @@ mod test {

use std::vec_ng::Vec;

fn is_freeze<T: Freeze>() {}
fn is_share<T: Share>() {}

// Assert that the AST remains Freeze (#10693).
// Assert that the AST remains sharable.
#[test]
fn ast_is_freeze() {
is_freeze::<Item>();
fn ast_is_share() {
is_share::<Item>();
}

// are ASTs encodable?
Expand Down
5 changes: 4 additions & 1 deletion src/libsyntax/util/interner.rs
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,16 @@ use std::hash::Hash;
use std::rc::Rc;
use std::vec_ng::Vec;

#[cfg(stage0)]
use std::kinds::Share;

pub struct Interner<T> {
priv map: RefCell<HashMap<T, Name>>,
priv vect: RefCell<Vec<T> >,
}

// when traits can extend traits, we should extend index<Name,T> to get []
impl<T:Eq + Hash + Freeze + Clone + 'static> Interner<T> {
impl<T: Eq + Hash + Share + Clone + 'static> Interner<T> {
pub fn new() -> Interner<T> {
Interner {
map: RefCell::new(HashMap::new()),
Expand Down
6 changes: 3 additions & 3 deletions src/test/auxiliary/issue-2526.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,17 +16,17 @@ struct arc_destruct<T> {
}

#[unsafe_destructor]
impl<T:Freeze> Drop for arc_destruct<T> {
impl<T: Share> Drop for arc_destruct<T> {
fn drop(&mut self) {}
}

fn arc_destruct<T:Freeze>(data: int) -> arc_destruct<T> {
fn arc_destruct<T: Share>(data: int) -> arc_destruct<T> {
arc_destruct {
_data: data
}
}

fn arc<T:Freeze>(_data: T) -> arc_destruct<T> {
fn arc<T: Share>(_data: T) -> arc_destruct<T> {
arc_destruct(0)
}

Expand Down
6 changes: 3 additions & 3 deletions src/test/compile-fail/builtin-superkinds-double-superkind.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@
// Test for traits that inherit from multiple builtin kinds at once,
// testing that all such kinds must be present on implementing types.

trait Foo : Send+Freeze { }
trait Foo : Send+Share { }

impl <T: Freeze> Foo for (T,) { } //~ ERROR cannot implement this trait
impl <T: Share> Foo for (T,) { } //~ ERROR cannot implement this trait

impl <T: Send> Foo for (T,T) { } //~ ERROR cannot implement this trait

impl <T: Send+Freeze> Foo for (T,T,T) { } // (ok)
impl <T: Send+Share> Foo for (T,T,T) { } // (ok)

fn main() { }
4 changes: 2 additions & 2 deletions src/test/compile-fail/builtin-superkinds-self-type.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@
// Tests (negatively) the ability for the Self type in default methods
// to use capabilities granted by builtin kinds as supertraits.

trait Foo : Freeze {
trait Foo : Share {
fn foo(self, mut chan: Sender<Self>) {
chan.send(self); //~ ERROR does not fulfill `Send`
}
}

impl <T: Freeze> Foo for T { }
impl <T: Share> Foo for T { }

fn main() {
let (tx, rx) = channel();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@

trait Foo : Send { }

impl <T: Freeze> Foo for T { } //~ ERROR cannot implement this trait
impl <T: Share> Foo for T { } //~ ERROR cannot implement this trait

fn main() { }
2 changes: 1 addition & 1 deletion src/test/compile-fail/cant-implement-builtin-kinds.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ struct X<T>(T);

impl <T> Send for X<T> { } //~ ERROR cannot provide an explicit implementation for a builtin kind
impl <T> Sized for X<T> { } //~ ERROR cannot provide an explicit implementation for a builtin kind
impl <T> Freeze for X<T> { } //~ ERROR cannot provide an explicit implementation for a builtin kind
impl <T> Share for X<T> { } //~ ERROR cannot provide an explicit implementation for a builtin kind

fn main() { }
8 changes: 4 additions & 4 deletions src/test/compile-fail/comm-not-freeze.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

fn test<T: Freeze>() {}
fn test<T: Share>() {}

fn main() {
test::<Sender<int>>(); //~ ERROR: does not fulfill `Freeze`
test::<Receiver<int>>(); //~ ERROR: does not fulfill `Freeze`
test::<Sender<int>>(); //~ ERROR: does not fulfill `Freeze`
test::<Sender<int>>(); //~ ERROR: does not fulfill `Share`
test::<Receiver<int>>(); //~ ERROR: does not fulfill `Share`
test::<Sender<int>>(); //~ ERROR: does not fulfill `Share`
}
2 changes: 1 addition & 1 deletion src/test/compile-fail/issue-2611-4.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ struct E {
}

impl A for E {
fn b<F:Freeze,G>(_x: F) -> F { fail!() } //~ ERROR type parameter 0 requires `Freeze`
fn b<F: Share, G>(_x: F) -> F { fail!() } //~ ERROR type parameter 0 requires `Share`
}

fn main() {}
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@

use std::kinds::marker;

fn foo<P:Freeze>(p: P) { }
fn foo<P: Share>(p: P) { }

fn main()
{
foo(marker::NoFreeze); //~ ERROR does not fulfill `Freeze`
foo(marker::NoShare); //~ ERROR does not fulfill `Share`
}
4 changes: 2 additions & 2 deletions src/test/compile-fail/mut-not-freeze.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@

use std::cell::RefCell;

fn f<T: Freeze>(_: T) {}
fn f<T: Share>(_: T) {}

fn main() {
let x = RefCell::new(0);
f(x); //~ ERROR: which does not fulfill `Freeze`
f(x); //~ ERROR: which does not fulfill `Share`
}
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@

use std::kinds::marker;

enum Foo { A(marker::NoFreeze) }
enum Foo { A(marker::NoShare) }

fn bar<T: Freeze>(_: T) {}
fn bar<T: Share>(_: T) {}

fn main() {
let x = A(marker::NoFreeze);
let x = A(marker::NoShare);
bar(x);
//~^ ERROR instantiating a type parameter with an incompatible type `Foo`,
// which does not fulfill `Freeze`
// which does not fulfill `Share`
}
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@
use std::rc::Rc;
use std::cell::RefCell;

fn bar<T: Freeze>(_: T) {}
fn bar<T: Share>(_: T) {}

fn main() {
let x = Rc::new(RefCell::new(5));
bar(x);
//~^ ERROR instantiating a type parameter with an incompatible type
// `std::rc::Rc<std::cell::RefCell<int>>`, which does not fulfill `Freeze`
// `std::rc::Rc<std::cell::RefCell<int>>`, which does not fulfill `Share`
}
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@

use std::kinds::marker;

struct Foo { a: int, m: marker::NoFreeze }
struct Foo { a: int, m: marker::NoShare }

fn bar<T: Freeze>(_: T) {}
fn bar<T: Share>(_: T) {}

fn main() {
let x = Foo { a: 5, m: marker::NoFreeze };
let x = Foo { a: 5, m: marker::NoShare };
bar(x);
//~^ ERROR instantiating a type parameter with an incompatible type `Foo`,
// which does not fulfill `Freeze`
// which does not fulfill `Share`
}
2 changes: 1 addition & 1 deletion src/test/run-pass/const-bound.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
// are const.


fn foo<T:Freeze>(x: T) -> T { x }
fn foo<T: Share>(x: T) -> T { x }

struct F { field: int }

Expand Down
2 changes: 1 addition & 1 deletion src/test/run-pass/issue-2611-3.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
// than the traits require.

trait A {
fn b<C:Freeze,D>(x: C) -> C;
fn b<C:Share,D>(x: C) -> C;
}

struct E {
Expand Down
14 changes: 7 additions & 7 deletions src/test/run-pass/trait-bounds-in-arc.rs
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,10 @@ pub fn main() {
let dogge1 = Dogge { bark_decibels: 100, tricks_known: 42, name: ~"alan_turing" };
let dogge2 = Dogge { bark_decibels: 55, tricks_known: 11, name: ~"albert_einstein" };
let fishe = Goldfyshe { swim_speed: 998, name: ~"alec_guinness" };
let arc = Arc::new(~[~catte as ~Pet:Freeze+Send,
~dogge1 as ~Pet:Freeze+Send,
~fishe as ~Pet:Freeze+Send,
~dogge2 as ~Pet:Freeze+Send]);
let arc = Arc::new(~[~catte as ~Pet:Share+Send,
~dogge1 as ~Pet:Share+Send,
~fishe as ~Pet:Share+Send,
~dogge2 as ~Pet:Share+Send]);
let (tx1, rx1) = channel();
let arc1 = arc.clone();
task::spawn(proc() { check_legs(arc1); tx1.send(()); });
Expand All @@ -83,21 +83,21 @@ pub fn main() {
rx3.recv();
}

fn check_legs(arc: Arc<~[~Pet:Freeze+Send]>) {
fn check_legs(arc: Arc<~[~Pet:Share+Send]>) {
let mut legs = 0;
for pet in arc.get().iter() {
legs += pet.num_legs();
}
assert!(legs == 12);
}
fn check_names(arc: Arc<~[~Pet:Freeze+Send]>) {
fn check_names(arc: Arc<~[~Pet:Share+Send]>) {
for pet in arc.get().iter() {
pet.name(|name| {
assert!(name[0] == 'a' as u8 && name[1] == 'l' as u8);
})
}
}
fn check_pedigree(arc: Arc<~[~Pet:Freeze+Send]>) {
fn check_pedigree(arc: Arc<~[~Pet:Share+Send]>) {
for pet in arc.get().iter() {
assert!(pet.of_good_pedigree());
}
Expand Down

0 comments on commit 12ecafb

Please sign in to comment.