This repository has been archived by the owner on Apr 5, 2024. It is now read-only.
Update cargo to 0.34 #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've run into similar issues when addressing the current CI failures, I'll have a look and see how much overlap is in our branches (and your other PR). |
|
I'm on zulip and discord if you have questions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates cargo to 0.34 (master) - cargo removed some APIs that rust-semverver was using
apparently accidentally, so I've filled in a PR to revert their removal: rust-lang/cargo#6517 . This PR currently points to my branch of cargo with that patch, and I'll update this PR to cargo 0.34 once it is properly released.Until then, it would be nice to check that this PR doesn't break anything on CI.EDIT: these APIs won't be re-added to cargo any time soon, and there are currently no alternatives available. We should probably stop depending on
cargoin the future as suggested in that PR, but that might need some major changes (I've filled an issue in thecargo_metadatarepo about how to proceed here: oli-obk/cargo_metadata#60). In the meantime the easiest thing is to just use a patched version of cargo.On my CI this PR succeeds except for the last step, running cargo semver on itself, because the last released version on crates.io does not compile anymore, but that failure is to be expected, and after 0.1.23 is released, the failure should go away.