Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax: raw identifiers #338

Merged
merged 2 commits into from
Sep 5, 2018
Merged

Conversation

ehuss
Copy link

@ehuss ehuss commented Aug 22, 2018

Raw identifiers are stabilized in 1.30.

Also updates the r#""# auto-match to cooperate with raw identifiers by triggering on the quote instead.

image

@ehuss ehuss changed the title Syntax raw identifier Syntax: raw identifier Aug 22, 2018
@ehuss ehuss changed the title Syntax: raw identifier Syntax: raw identifiers Aug 22, 2018
@ehuss
Copy link
Author

ehuss commented Aug 22, 2018

The r# part of the identifier currently doesn't get any special scope. I expect their usage to be extremely rare, and I'm not sure it is justified to complicate the syntax even more for this unusual feature.

@ehuss
Copy link
Author

ehuss commented Sep 5, 2018

bors r+

@bors
Copy link

bors bot commented Sep 5, 2018

Merge conflict (retrying...)

1 similar comment
@bors
Copy link

bors bot commented Sep 5, 2018

Merge conflict (retrying...)

@bors
Copy link

bors bot commented Sep 5, 2018

Merge conflict

Raw identifiers are stabilized in 1.30.
This changes it so that it triggers on the quote instead of the #.
@ehuss
Copy link
Author

ehuss commented Sep 5, 2018

bors r+

bors bot added a commit that referenced this pull request Sep 5, 2018
338: Syntax: raw identifiers r=ehuss a=ehuss

Raw identifiers are stabilized in 1.30.

Also updates the `r#""#` auto-match to cooperate with raw identifiers by triggering on the quote instead.

<img width="727" alt="image" src="https://user-images.githubusercontent.com/43198/44490340-fb449c80-a612-11e8-81ae-837c036222da.png">


Co-authored-by: Eric Huss <[email protected]>
@bors
Copy link

bors bot commented Sep 5, 2018

Build succeeded

@bors bors bot merged commit 4c3d9fe into rust-lang:master Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant