Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move UNINLINED_FORMAT_ARGS to pedantic #9728

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

dswij
Copy link
Member

@dswij dswij commented Oct 27, 2022

As discussed in zulip, we are moving this lint to pedantic to be backported

changelog: [UNINLINED_FORMAT_ARGS]: move to pedantic

@rust-highfive
Copy link

r? @giraffate

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 27, 2022
@dswij dswij added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 27, 2022
@flip1995
Copy link
Member

@bors r+

Let's get this in now. I will backport it to rustc this evening.

@bors
Copy link
Collaborator

bors commented Oct 27, 2022

📌 Commit 14a34c2 has been approved by flip1995

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Oct 27, 2022

⌛ Testing commit 14a34c2 with merge 710999d...

@bors
Copy link
Collaborator

bors commented Oct 27, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 710999d to master...

@bors bors merged commit 710999d into rust-lang:master Oct 27, 2022
@dswij dswij deleted the uninlined-fargs-pedantic branch October 27, 2022 13:23
@flip1995 flip1995 added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Oct 27, 2022
@flip1995
Copy link
Member

rust-lang/rust#103654

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 28, 2022
Move clippy::uninlined_format_args back to pedantic

Before `beta` is branched tomorrow we want to move this lint back to `pedantic` so that it is not enabled by default.

Clippy PR: rust-lang/rust-clippy#9728
Zulip discussion: https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/.60uninlined_format_args.60.20category/near/306306974

r? `@Manishearth`
@flip1995 flip1995 removed the beta-accepted Accepted for backporting to the compiler in the beta channel. label Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants