-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track clippy.toml
and Cargo.toml
in file_depinfo
#9707
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties
label
Oct 24, 2022
Alexendoo
force-pushed
the
file-depinfo
branch
2 times, most recently
from
October 24, 2022 21:10
468ba1e
to
c07ab80
Compare
flip1995
approved these changes
Oct 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just one question. r=me if the tempfile dep cannot be removed.
Causes cargo to re-run clippy when those paths are modified Also tracks the path to `clippy-driver` in debug mode to remove the workarounds in `cargo dev lint` and `lintcheck`
Alexendoo
force-pushed
the
file-depinfo
branch
from
October 25, 2022 11:33
c07ab80
to
bd83690
Compare
@bors r+ Thanks! |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This was referenced Oct 25, 2022
bors
added a commit
that referenced
this pull request
Oct 26, 2022
Remove note mentioning configuration changes need cargo clean Missed this in #9707 changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Causes cargo to re-run clippy when those paths are modified
Also tracks the path to
clippy-driver
in debug mode to remove the workarounds incargo dev lint
andlintcheck
(cc @matthiaskrgr)changelog: Automatically re-run Clippy if
Cargo.toml
orclippy.toml
are modifiedFixes #2130
Fixes #8512
r? @flip1995