s/PatKind::Ident/PatKind::Binding/g #970
Conversation
|
Still fails Travis. Also, version+changelog bump? |
|
First it has to work. Something changed beyond the name... |
|
You missed one. |
|
The copies lint appears to find more matches now, which is nice. I'm a bit stumped on the matches test, though. @mcarton any idea? |
|
This can warn: let _ = match Some(42) {
Some(_) => 24,
None => 24, //~ERROR this `match` has identical arm bodies
};It looks like This should not: let _ = match Some(42) {
Some(foo) => 24,
None => 24,
};So you might want to add this in the test. It also looks like you might need to rebase your local copy, there is still one |
|
For the match test you might need |
| @@ -145,7 +145,7 @@ impl<'a, 'tcx: 'a> SpanlessEq<'a, 'tcx> { | |||
| (&PatKind::TupleStruct(ref lp, ref la, ls), &PatKind::TupleStruct(ref rp, ref ra, rs)) => { | |||
| self.eq_path(lp, rp) && over(la, ra, |l, r| self.eq_pat(l, r)) && ls == rs | |||
| } | |||
| (&PatKind::Ident(ref lb, ref li, ref lp), &PatKind::Ident(ref rb, ref ri, ref rp)) => { | |||
There was a problem hiding this comment.
You might also want to add PatKind::Path here and add some tests for it. Something like:
if let None = Some(42) {
} else if let None = Some(42) {
}
See rust-lang/rust#31685.
|
Now on to matches... |
| @@ -200,7 +200,8 @@ fn check_single_match_opt_like(cx: &LateContext, ex: &Expr, arms: &[Arm], expr: | |||
| } | |||
| path.to_string() | |||
| } | |||
| PatKind::Ident(BindByValue(MutImmutable), ident, None) => ident.node.to_string(), | |||
| PatKind::Binding(BindByValue(MutImmutable), ident, None) => ident.node.to_string(), | |||
| PatKind::Path(ref path) => path.to_string(), | |||
There was a problem hiding this comment.
Is Binding really necessary here? My understanding was that variant were now resolved (and we only care about some known paths).
There was a problem hiding this comment.
I'm not sure, but I'm tired now and have to get up early tomorrow.
|
Looks like you failed your rebase/merge, some commits from master have appeared in the PR with a different hash. |
|
I guess we can squash on merging. 😉 |
Rustup to *rustc 1.10.0-nightly (7bddce6 2016-05-27)*
This failed the most recent build.