Fix sorting in cargo dev update_lints script
#9509
Conversation
|
r? @Manishearth (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@Manishearth, do you have any thoughts on this? An alternative way of fixing this would be to simply remove |
|
Manish seems to be pretty busy lately. So I've just had a look and I think it makes sense to sort; makes it easier to find things. Thank you for making clippy better and sorry you had to wait for so long. @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
|
Oh, sorry, I must have missed the original ping Yeah, this seems fine, thanks for stepping in @llogiq ! |
Add `collection_is_never_read` Fixes #9267 `@flip1995` and `@llogiq,` I talked with you about this one at Rust Nation in London last week. :-) This is my first contribution to Clippy, so lots of feedback would be greatly appreciated. - \[ ] Followed [lint naming conventions][lint_naming] - \[x] Added passing UI tests (including committed `.stderr` file) - \[x] `cargo test` passes locally - \[x] Executed `cargo dev update_lints` - \[x] Added lint documentation - \[x] Run `cargo dev fmt` `dogfood` found one true positive (see #9509) and no false positives. `lintcheck` found no (true or false) positives, even when running on an extended set of crates. --- changelog: new lint [`collection_is_never_read`] [#10415](#10415) <!-- changelog_checked -->
changelog: none
The old code cloned and sorted
usable_lintsintosorted_usable_lints, but then failed to do anything withsorted_usable_lints.This was discovered by my new
collection_is_never_readlint (#9267) that I'm working on!Fix: I renamed the sorted vector to
usable_lints. Therefore it now gets used where the unsorted one was used previously.