update most tests to 2021 edition #7866
Conversation
|
r? @Manishearth (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@Manishearth do you want to release a compiletest-rs version so we don't have to use the master (or the current commit)? |
|
@llogiq can you make a PR bumping the revision? |
|
Done. |
|
(and published) |
llogiq
force-pushed
the
edition-2021-tests
branch
from
194642a
to
eb07369
Compare
|
Can you add comments for why certain tests are pinned to 2015? |
|
☔ The latest upstream changes (presumably #7810) made this pull request unmergeable. Please resolve the merge conflicts. |
llogiq
force-pushed
the
edition-2021-tests
branch
from
eb07369
to
c1dc00d
Compare
|
I haven't finished all of the tests. Will hopefully finish them shortly. |
llogiq
force-pushed
the
edition-2021-tests
branch
2 times, most recently
from
8ae099f
to
23fc9a7
Compare
llogiq
force-pushed
the
edition-2021-tests
branch
from
23fc9a7
to
a4ede72
Compare
|
@Manishearth r? |
| @@ -1,10 +1,12 @@ | |||
| //edition:2015 | |||
| //FIXME: The lint only triggers once on edition 2021, so I'm leaving this at 2015 for now. | |||
| // the 2015 edition here is needed because edition 2018 changed the module system | ||
| // (see https://doc.rust-lang.org/edition-guide/rust-2018/path-changes.html) which means the lint | ||
| // no longer detects some of the cases starting with Rust 2018. | ||
| // FIXME: We should likely add another edition 2021 test case for this lint |
| // run-rustfix | ||
| // aux-build:wildcard_imports_helper.rs | ||
|
|
||
| // the 2015 edition here is needed because edition 2018 changed the module system |
|
@bors r+ |
|
📌 Commit a4ede72 has been approved by |
|
Please file issues for the fixmes |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
|
I filed issues for the files still on the 2015 edition. |
Some tests would no longer work at all, so I added
edition:2015oredition:2018to them.Notably 2021 panics are not yet detected correctly. Once ready, this closes #7842.
changelog: none