Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify use_self impl #7411

Merged
merged 4 commits into from
Jun 29, 2021
Merged

Simplify use_self impl #7411

merged 4 commits into from
Jun 29, 2021

Conversation

camsteffen
Copy link
Contributor

changelog: none

Mainly to remove an extra visit and simplify the "in body?" logic.

@rust-highfive
Copy link

r? @phansch

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 28, 2021
flip1995
flip1995 reviewed Jun 29, 2021
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is type_of a new query or did I just totally miss that when I implemented this? 🤔

Changes LGTM overall, so small things I noticed.

clippy_lints/src/use_self.rs Outdated Show resolved Hide resolved
clippy_lints/src/use_self.rs Outdated Show resolved Hide resolved
clippy_lints/src/use_self.rs Outdated Show resolved Hide resolved
@flip1995
Copy link
Member

r? @flip1995

@bors try (Just to make sure that this doesn't ICE. I'm really wary about the in_body handling, since this made the most problems for me when implementing this)

I'll also run the lintcheck tool if the try build succeeds.

@bors
Copy link
Contributor

bors commented Jun 29, 2021

⌛ Trying commit 0e2119c with merge c2abe08...

bors added a commit that referenced this pull request Jun 29, 2021
@bors
Auto merge of #7411 - camsteffen:use-self-visitor, r=<try>
c2abe08 
Simplify use_self impl

changelog: none

Mainly to remove an extra visit and simplify the "in body?" logic.
@flip1995 flip1995 assigned flip1995 and unassigned phansch Jun 29, 2021
@bors
Copy link
Contributor

bors commented Jun 29, 2021

☀️ Try build successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Build commit: c2abe08 (c2abe08e354a7937e1c5de3e66a7e7ba8c129eb7)

@camsteffen
Copy link
Contributor Author

Comments are addressed!

Is type_of a new query or did I just totally miss that when I implemented this? 🤔

I think it's not new? I randomly discovered one time that it can be used on impl blocks - certainly not very obvious.

@flip1995
Copy link
Member

@bors r+

Thanks! (Also passed my lintcheck run locally)

@bors
Copy link
Contributor

bors commented Jun 29, 2021

📌 Commit bae76f9 has been approved by flip1995

@bors
Copy link
Contributor

bors commented Jun 29, 2021

⌛ Testing commit bae76f9 with merge fbd77ef...

@bors
Copy link
Contributor

bors commented Jun 29, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing fbd77ef to master...

@bors bors merged commit fbd77ef into rust-lang:master Jun 29, 2021
@dtolnay dtolnay mentioned this pull request Jul 3, 2021
Closed
@camsteffen camsteffen deleted the use-self-visitor branch July 8, 2021 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flip1995 flip1995 flip1995 left review comments

Assignees

@flip1995 flip1995

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@camsteffen @rust-highfive @flip1995 @bors @phansch