Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positive in await_holding_* lints #6355

Closed
wants to merge 1 commit into from
Closed

Fix false positive in await_holding_* lints #6355

wants to merge 1 commit into from

Conversation

Daniel-B-Smith
Copy link

@Daniel-B-Smith Daniel-B-Smith commented Nov 20, 2020 •
edited by ebroto
Loading

Fixes #6353
Fixes #6446

TODO: Add more detail when actually fixed

@rust-highfive
Copy link

r? @llogiq

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 20, 2020
@flip1995
Copy link
Member

flip1995 commented Nov 20, 2020 •
edited
Loading

r? @flip1995 Taking this PR, because I r+ed the initial addition of this lint IIRC

@rust-highfive rust-highfive assigned flip1995 and unassigned llogiq Nov 20, 2020
@Daniel-B-Smith
Copy link
Author

At the moment, this PR is just the failing test case. I posted this in the Zulip as well. I had been optimistic that there was an easy way to access if a variable had been dropped, but I wasn't able to find anything. If you had any pointers to help me get started, that would be greatly appreciated.

@flip1995 flip1995 added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Jan 17, 2021
@giraffate
Copy link
Contributor

ping from triage @Daniel-B-Smith. Could you have any update on this?

@Daniel-B-Smith
Copy link
Author

Unfortunately, from discussions on Zulip, it seems that this will be more challenging than I currently have time to attempt. A comment about the limitation of the lint has been merged. I can close this PR so that it doesn't show up on any triage boards.

@Daniel-B-Smith Daniel-B-Smith deleted the refcell_ref_await branch February 5, 2021 17:33
@giraffate giraffate added S-inactive-closed Status: Closed due to inactivity and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@flip1995 flip1995

Labels
S-inactive-closed Status: Closed due to inactivity
Projects
None yet
Milestone
No milestone
5 participants
@Daniel-B-Smith @rust-highfive @flip1995 @giraffate @llogiq