Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the criteria of interior_mutable_const #6046

Merged
merged 3 commits into from
Sep 18, 2020
Merged

Change the criteria of interior_mutable_const #6046

merged 3 commits into from
Sep 18, 2020

Commits on Sep 17, 2020

  1. Change the criteria of interior_mutable_const 

    * stop linting associated types and generic type parameters
* start linting ones in trait impls
  whose corresponding definitions in the traits are generic
* remove the `is_copy` check
  as presumably the only purpose of it is to allow
  generics with `Copy` bounds as `Freeze` is internal
  and generics are no longer linted
* remove the term 'copy' from the tests
  as being `Copy` no longer have meaning
    @rail-rain
    rail-rain committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    d655c0a View commit details
    Browse the repository at this point in the history

  2. rewrite the test and fix a minor fp 

    * rewrite the test for `declare_interior_mutable_const from scratch`

* fix a minor false positive where `Cell<"const T>` gets linted twice
    @rail-rain
    rail-rain committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    2fc9064 View commit details
    Browse the repository at this point in the history

  3. add WRAPPED_SELF: Option<Self> in the test

    @rail-rain
    rail-rain committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    d5af360 View commit details
    Browse the repository at this point in the history