Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict same_item_push to suppress false positives #6016

Merged
merged 6 commits into from
Sep 8, 2020
Merged

Restrict same_item_push to suppress false positives #6016

merged 6 commits into from
Sep 8, 2020

Commits on Sep 7, 2020

  1. Restrict same_item_push to suppress false positives 

    It emits a lint when the pushed item is a literal, a constant and an immutable binding that are initialized with those.
    @giraffate
    giraffate committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    3d30ef7 View commit details
    Browse the repository at this point in the history

  2. Refactoring: use inner function

    @giraffate
    giraffate committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    619ca76 View commit details
    Browse the repository at this point in the history

  3. Some refactoring

    @giraffate
    giraffate committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    5d085ad View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2020

  1. Add some tests to same_item_push 

    Add tests in which the variable is initialized with a match expression and function call
    @giraffate
    giraffate committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    2c9f82e View commit details
    Browse the repository at this point in the history

  2. Refactoring: tests in same_item_push

    @giraffate
    giraffate committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    952c046 View commit details
    Browse the repository at this point in the history

  3. Address items_after_statement

    @giraffate
    giraffate committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    1d8ae3a View commit details
    Browse the repository at this point in the history