Downgrade implicit_hasher to pedantic

[dtolnay]

From the documentation, this lint is intended to suggest:

- pub fn foo(map: &mut HashMap<i32, i32>) { }

+ pub fn foo<S: BuildHasher>(map: &mut HashMap<i32, i32, S>) { }

I think this is pedantic. I get that this lint can benefit core libraries like serde, but that's exactly the use case for pedantic lints; a library like serde will enable clippy_pedantic and take the time to go through everything possible. Similar for libraries doing a libz blitz style checkup before committing to a 1.0 release; it would make sense to run through all the available pedantic lints then.

But otherwise, for most codebases and certainly for industrial codebases, the above suggested change just makes the codebase more obtuse for questionable benefit.

changelog: Remove implicit_hasher from default set of enabled lints

[flip1995]

Agreed. I also hit this lint in small code bases sometimes and think for my self "Yeah, I could do this, but that isn't necessary for my use-case at all" and then just allow it. Waiting for GHA to get fixed.

[flip1995]

@bors r+ rollup

[bors]

📌 Commit 0982b67 has been approved by flip1995

[bors]

🌲 The tree is currently closed for pull requests below priority 2, this pull request will be tested once the tree is reopened

[bors]

☔ The latest upstream changes (presumably #5438) made this pull request unmergeable. Please resolve the merge conflicts.

[flip1995]

@dtolnay a rebase is required after the rollup #5438

[bors]

🔒 Merge conflict

This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.

How do I rebase?

Assuming self is your fork and upstream is this repository, you can resolve the conflict following these steps:

1. git checkout hasher (switch to your branch)
2. git fetch upstream master (retrieve the latest master)
3. git rebase upstream/master -p (rebase on top of it)
4. Follow the on-screen instruction to resolve conflicts (check git status if you got lost).
5. git push self hasher --force-with-lease (update this PR)

You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial.

Please avoid the "Resolve conflicts" button on GitHub. It uses git merge instead of git rebase which makes the PR commit history more difficult to read.

Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Cargo.lock conflict is handled during merge and rebase. This is normal, and you should still perform step 5 to update this PR.

Error message

Auto-merging src/lintlist/mod.rs
Auto-merging clippy_lints/src/types.rs
Auto-merging clippy_lints/src/lib.rs
CONFLICT (content): Merge conflict in clippy_lints/src/lib.rs
Automatic merge failed; fix conflicts and then commit the result.

[dtolnay]

Rebased.

[flip1995]

@bors r+

[bors]

📌 Commit 5f92fae has been approved by flip1995

[bors]

⌛ Testing commit 5f92fae with merge c25f26d...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing c25f26d to master...