-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash in use-self
lint
#4776
Conversation
The compiler creates paths for the range syntax ( I based the setup for the ice test on the "backtrace-debuginfo" ui test in the compiler. I don't like creating an ignored test for the submodule but I couldn't find a better way. There is another problem in the code related to this issue around primitive types that don't have a def_id. I'll document it in another issue later. |
Just noticed some problems with this PR. I'll update later... |
This should be good now. Just waiting on build fixes to be merged. |
tests/ui/crashes/ice-4727-aux.rs
Outdated
@@ -0,0 +1,13 @@ | |||
//ignore-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can move this file in the auxiliary dir, so you don't have to ignore it, like
macro_rules! use_self { |
which is used in
rust-clippy/tests/ui/ice-4671.rs
Lines 4 to 5 in 43a3796
#[path = "auxiliary/use_self_macro.rs"] | |
mod use_self_macro; |
@bors r+ Thanks! |
📌 Commit cc6e27f has been approved by |
Fix crash in `use-self` lint Fixes #4727 changelog: Fix crash in `use-self` lint
@bors retry, to prioritize rustup |
@bors retry |
@bors treeclosed- |
Fix crash in `use-self` lint Fixes #4727 changelog: Fix crash in `use-self` lint
☀️ Test successful - checks-travis, status-appveyor |
Fixes #4727
changelog: Fix crash in
use-self
lint