Add negation to len_zero lint to show more explicit message.
#4314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flip1995
approved these changes
Jul 31, 2019
tests/ui/escape_analysis.stderr
Outdated
| @@ -1,22 +0,0 @@ | |||
| error: local variable doesn't need to be boxed here | |||
flip1995
added
the
S-waiting-on-author
chansuke
force-pushed
the
add-negation-to-is_empty
branch
from
293b0d7 to
2d467dc
Compare
|
Oh, now you have to update the |
|
@flip1995 Oh, my bad. I pushed updated |
|
Thanks! @bors r+ Side note: If your contribution fixes an issue, add "Fixes/Resolves/Closes" in front of the issue number, so the issue gets closed automatically. (Also in Clippy we require a "changelog: ..." line in the description). I added those for you, so this is just FYI and your next Clippy contribution 🎉 😉 |
|
📌 Commit ccc3257 has been approved by |
bors
added a commit
that referenced
this pull request
Aug 1, 2019
Add negation to `len_zero` lint to show more explicit message. Fixes #4304 I have updated the `len_zero` to show the required negation in case of like the below case. ``` fn main() { let v = vec![1]; if v.len() > 0 { } } ``` changelog: Clarify suggestion of `len_zero` lint.
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4304 I have updated the
len_zeroto show the required negation in case of like the below case.changelog: Clarify suggestion of
len_zerolint.