Improve get_unwrap suggestion
#3638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle case where a reference is immediately dereferenced. Fixes 3625
detrumi
reviewed
Jan 6, 2019
detrumi
reviewed
Jan 6, 2019
| | | ||
| LL | *some_vecdeque.get_mut(0).unwrap() = 1; | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&mut some_vecdeque[0]` |
There was a problem hiding this comment.
All changed tests were get_mut() cases, maybe there should be a test for a get() case too?
|
I made the changes suggested. |
|
@bors r+ another bug bites the dust |
|
📌 Commit d2ea635 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 7, 2019
Improve `get_unwrap` suggestion Handle case where a reference is immediately dereferenced. Fixes #3625
|
☀️ Test successful - status-appveyor, status-travis |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle case where a reference is immediately dereferenced.
Fixes #3625