Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustup, fix breakage introduced by https://github.com/rust-lang/rust/pull/53581 #3072

Merged
merged 3 commits into from
Aug 23, 2018

Conversation

matthiaskrgr
Copy link
Member

Is there a way to run the tests from the rustc repos clippy_lints package?

@Manishearth
Copy link
Member

Is there a way to run the tests from the rustc repos clippy_lints package?

Why? Just run the tests from this repo?

If you need a rustc to run this with, use https://github.com/kennytm/rustup-toolchain-install-master (rustup-toolchain-install-master -n master -f)

@matthiaskrgr
Copy link
Member Author

Ok, I got it to build but a lot of tests fail, it looks like run-pass chooses the wrong compiler (nightly instead of master) 🤷‍♂️

@matthiaskrgr
Copy link
Member Author

AAAAH the rust-toolchain file was overriding back to nightly behind my back....

I removed it for testing, and all tests pass except for dogfood

Caused by:
  process didn't exit successfully: `/home/matthias/vcs/github/rust-clippy/target/debug/clippy-driver /home/matthias/.rustup/toolchains/master/bin/rustc - --crate-name ___ --print=file-names -C target-cpu=native --crate-type bin --crate-type rlib --crate-type dylib --crate-type cdylib --crate-type staticlib --crate-type proc-macro` (exit code: 101)
--- stderr
error: multiple input filenames provided

@matthiaskrgr
Copy link
Member Author

matthiaskrgr commented Aug 22, 2018

(However since clippy compiled fine I assume that dogfood failure is only due to me using the rustc master version wrongly)

@flip1995
Copy link
Member

Have you tried cargo +master test or how it should be done in CI one day: setting rustup default master and then just cargo test?

@matthiaskrgr
Copy link
Member Author

Ok, I found my mistake, all tests pass now 🎉

flip1995 and others added 2 commits August 23, 2018 15:36
Warning was:
warning: the feature `macro_vis_matcher` has been stable since 1.29.0 and no longer requires an attribute to enable
 --> src/lib.rs:4:12
  |
4 | #![feature(macro_vis_matcher)]
  |            ^^^^^^^^^^^^^^^^^
  |
  = note: #[warn(stable_features)] on by default
@flip1995
Copy link
Member

Thanks, the tool_attributes feature stabilization was merged a few hours ago. I added that here.

All tests pass for me locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants