Misc refactorings #13050
Merged
Misc refactorings #13050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Check HIR beffore type checking * Only lint when `Arc::new` is called
* Don't clone the token stream * Check the HIR tree before reading attributes
rustbot
added
the
S-waiting-on-review
|
r? @xFrednet |
xFrednet
approved these changes
Jul 22, 2024
|
LGTM. With this one, I'm pretty sure that it'll conflict with one of my PRs. I forgot how it was to approve PRs with this knowledge :O Anyway, thank you for the changes! Roses are red, |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various small re-orderings to check the HIR tree or AST before doing other checks. Also includes a small bug fix for
arc_with_small_send_syncnot actually checking forArc::new.changelog: none