Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pointers cannot be converted to integers at compile time #12403

Merged
merged 1 commit into from
Mar 3, 2024
Merged

Pointers cannot be converted to integers at compile time #12403

merged 1 commit into from
Mar 3, 2024

Conversation

samueltardieu
Copy link
Contributor

@samueltardieu samueltardieu commented Mar 3, 2024 •
edited
Loading

Fix #12402

changelog: [transmutes_expressible_as_ptr_casts]: do not suggest invalid const casts

@rustbot
Copy link
Collaborator

rustbot commented Mar 3, 2024

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 3, 2024
blyxyas
blyxyas requested changes Mar 3, 2024
View reviewed changes
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nit just to make sure that this doesn't happen again.

tests/ui/transmutes_expressible_as_ptr_casts.fixed Outdated Show resolved Hide resolved
blyxyas
blyxyas approved these changes Mar 3, 2024
View reviewed changes
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ❤️

@blyxyas
Copy link
Member

blyxyas commented Mar 3, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Mar 3, 2024

📌 Commit 6e5332c has been approved by blyxyas

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Mar 3, 2024

⌛ Testing commit 6e5332c with merge c2dd413...

@bors
Copy link
Contributor

bors commented Mar 3, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: blyxyas
Pushing c2dd413 to master...

@bors bors merged commit c2dd413 into rust-lang:master Mar 3, 2024
5 checks passed
@samueltardieu samueltardieu deleted the issue-12402 branch September 2, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blyxyas blyxyas blyxyas approved these changes

Assignees

@blyxyas blyxyas

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
4 participants
@samueltardieu @rustbot @blyxyas @bors