Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mir_to_const improvements #11565

Merged
merged 3 commits into from
Sep 28, 2023
Merged

mir_to_const improvements #11565

merged 3 commits into from
Sep 28, 2023

Conversation

RalfJung
Copy link
Member

This simplifies some code and also fixes the float array handling to properly take into account the offset, and to work with little-endian targets.

Fixes #11488
changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Sep 25, 2023

r? @Jarcho

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 25, 2023
@Jarcho
Copy link
Contributor

Jarcho commented Sep 28, 2023

Thanks for fixing this. I can take this off my todo list. @bors r+

@bors
Copy link
Contributor

bors commented Sep 28, 2023

📌 Commit 0f19857 has been approved by Jarcho

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 28, 2023

⌛ Testing commit 0f19857 with merge 91997a4...

@bors
Copy link
Contributor

bors commented Sep 28, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Jarcho
Pushing 91997a4 to master...

@bors bors merged commit 91997a4 into rust-lang:master Sep 28, 2023
@RalfJung RalfJung deleted the mir_to_const branch March 31, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

miri_to_const bug on big-endian targets
4 participants