Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow calling to_owned on borrowed value for [implicit_clone] #11321

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

J-ZhengLi
Copy link
Member

fixes: #11281

a small and simple fix that give up checking for referenced_value.to_owned() usage.

changelog: allow calling to_owned with borrowed value for [implicit_clone]

@rustbot
Copy link
Collaborator

rustbot commented Aug 11, 2023

r? @giraffate

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 11, 2023
@J-ZhengLi J-ZhengLi changed the title allow calling to_owned with borrowed value for [implicit_clone] allow calling to_owned on borrowed value for [implicit_clone] Aug 11, 2023
@bors
Copy link
Collaborator

bors commented Aug 11, 2023

☔ The latest upstream changes (presumably #11239) made this pull request unmergeable. Please resolve the merge conflicts.

Copy link
Contributor

@giraffate giraffate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, thanks!

Can we resolve the conflict?

@J-ZhengLi
Copy link
Member Author

Overall looks good, thanks!

Can we resolve the conflict?

👍 yep~ conflict resolved

@giraffate
Copy link
Contributor

@bors r+

Thanks!

@bors
Copy link
Collaborator

bors commented Aug 15, 2023

📌 Commit aa8995e has been approved by giraffate

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Aug 15, 2023

⌛ Testing commit aa8995e with merge 11efa01...

@bors
Copy link
Collaborator

bors commented Aug 15, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: giraffate
Pushing 11efa01 to master...

@bors bors merged commit 11efa01 into rust-lang:master Aug 15, 2023
4 checks passed
@J-ZhengLi J-ZhengLi deleted the issue11281 branch August 15, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implicit_clone shouldn't lint when called on a reference
4 participants