Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clippy Book Chapter Updates Reborn: Method Checking #10644

Merged
merged 4 commits into from
Aug 16, 2023

Conversation

blyxyas
Copy link
Member

@blyxyas blyxyas commented Apr 13, 2023

This PR adds a new chapter to the book: "Method Checking". Some major re-phrasing was done and some changes in the code comments (apart from grammar and minor changes).

Notes

changelog: Add a new "Method Checking" chapter to the book.

r? @flip1995

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 13, 2023
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of it LGTM. Let's fix/discuss the rest.

book/src/development/method_checking.md Outdated Show resolved Hide resolved
book/src/development/method_checking.md Outdated Show resolved Hide resolved
book/src/development/method_checking.md Show resolved Hide resolved
@bors
Copy link
Contributor

bors commented Apr 16, 2023

☔ The latest upstream changes (presumably #10652) made this pull request unmergeable. Please resolve the merge conflicts.

@blyxyas blyxyas force-pushed the book-method_checking branch 2 times, most recently from da12117 to 77c22aa Compare April 17, 2023 21:09
@blyxyas
Copy link
Member Author

blyxyas commented Apr 18, 2023

I think the latest commit fixes the issues shown in the reviews.

Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Rebased and formatted.

I'm concerned that PRs for the new chapters might get blocked by our link checker, because those new chapters that are linked in here are not yet upstream. But in the meantime we can just replace them with FIXMEs.

If anything should fail during merge, feel free to r=me after swapping out the links with FIXMEs.

@flip1995
Copy link
Member

print.html:2183: broken link - `development/define_lints.html`
development/method_checking.html:191: broken link - `development/define_lints.html

Should be fixed after #10595 is merged.

@flip1995
Copy link
Member

@bors r+ :shipit:

@bors
Copy link
Contributor

bors commented Aug 16, 2023

📌 Commit 1dbc8dd has been approved by flip1995

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Aug 16, 2023

⌛ Testing commit 1dbc8dd with merge d43486d...

@bors
Copy link
Contributor

bors commented Aug 16, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing d43486d to master...

@bors bors merged commit d43486d into rust-lang:master Aug 16, 2023
3 checks passed
@blyxyas blyxyas deleted the book-method_checking branch October 5, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants