-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clippy Book Chapter Updates Reborn: Method Checking #10644
Conversation
1055bce
to
c88e3f5
Compare
c88e3f5
to
6cc5efb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of it LGTM. Let's fix/discuss the rest.
☔ The latest upstream changes (presumably #10652) made this pull request unmergeable. Please resolve the merge conflicts. |
da12117
to
77c22aa
Compare
I think the latest commit fixes the issues shown in the reviews. |
77c22aa
to
e3a0218
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Rebased and formatted.
I'm concerned that PRs for the new chapters might get blocked by our link checker, because those new chapters that are linked in here are not yet upstream. But in the meantime we can just replace them with FIXME
s.
If anything should fail during merge, feel free to r=me
after swapping out the links with FIXME
s.
Should be fixed after #10595 is merged. |
Co-authored-by: Nahua <[email protected]>
e3a0218
to
e8d79b8
Compare
@bors r+ |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This PR adds a new chapter to the book: "Method Checking". Some major re-phrasing was done and some changes in the code comments (apart from grammar and minor changes).
Notes
changelog: Add a new "Method Checking" chapter to the book.
r? @flip1995