Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Travis Windows: Secret ENV vars break the build #3306

Closed
phansch opened this issue Oct 12, 2018 · 7 comments · Fixed by #3418
Closed

Travis Windows: Secret ENV vars break the build #3306

phansch opened this issue Oct 12, 2018 · 7 comments · Fixed by #3418
Labels
C-bug Category: Clippy is not doing the correct thing S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work

Comments

@phansch
Copy link
Member

phansch commented Oct 12, 2018 •
edited
Loading

The previous build issues are resolved. Now the UI tests are failing:

https://travis-ci.org/rust-lang-nursery/rust-clippy/jobs/440797682#L746

I'm not sure what the problem is. The stderr diffs look the same on the first glance.
@mati865
Copy link
Contributor

mati865 commented Oct 13, 2018

I bet it's the line endings conversion (CLRF <-> LF).
Git for Windows can be configured to leave them intact or convert them to chosen format. Repository is already checked out so you can play with dos2unix and unix2dos from C:\Program Files\Git\usr\bin to get matching endings.

@phansch phansch added the C-bug Category: Clippy is not doing the correct thing label Oct 26, 2018
@phansch phansch assigned phansch and unassigned phansch Oct 26, 2018
@phansch phansch mentioned this issue Oct 28, 2018
Closed
@phansch
Copy link
Member Author

phansch commented Oct 29, 2018

It was worth a try, but using unix2dos didn't seem to make a difference.

Some thoughts:

I'm not really sure how to effectively debug this without a windows machine, so I'll leave this to someone else.

@mati865
Copy link
Contributor

mati865 commented Oct 29, 2018 •
edited
Loading

  • Appveyor runs build script in Powershell while Travis Windows does it in Git for Windows BASH. WSL would give Linux like environment.
  • I diffed the expected and actual outputs on Travis and they are identical but test diff prints all likes like they were different.
  • LGTM

Have you tried with dos2unix?

edit: I can try it later on Windows with 64 GNU toolchain but I think it will run fine because I have git configured correctly.

@mati865
Copy link
Contributor

mati865 commented Oct 29, 2018 •
edited
Loading

Just tested on Windows and all tests pass.

phansch added a commit to phansch/rust-clippy that referenced this issue Nov 7, 2018
@phansch
Fix Travis Windows build
19770af 
Closes rust-lang#3306
@phansch phansch mentioned this issue Nov 7, 2018
Merged
phansch added a commit to phansch/rust-clippy that referenced this issue Nov 7, 2018
@phansch
Fix Travis Windows build
1bfdf31 
Closes rust-lang#3306
bors bot added a commit that referenced this issue Nov 10, 2018
@bors @phansch
Merge #3418
044023d 
3418: Fix Travis Windows build r=flip1995 a=phansch

Closes #3306

Co-authored-by: Philipp Hansch <[email protected]>
bors bot added a commit that referenced this issue Nov 10, 2018
@bors @phansch
Merge #3418
dabcc0e 
3418: Fix Travis Windows build r=flip1995 a=phansch

Closes #3306

Co-authored-by: Philipp Hansch <[email protected]>
bors bot added a commit that referenced this issue Nov 11, 2018
@bors @phansch
Merge #3418
577f1a3 
3418: Fix Travis Windows build r=flip1995 a=phansch

Closes #3306

Co-authored-by: Philipp Hansch <[email protected]>
@phansch
Copy link
Member Author

phansch commented Nov 28, 2018

See #3418 for the latest attempt to fix the windows build. We have to wait for a fix from Travis CI related to secret environment variables. With the mentioned PR, the windows build would still fail on master, as that's where the environment variables are used.

phansch added a commit to phansch/rust-clippy that referenced this issue Dec 2, 2018
@phansch
Enforce LF lineendings for everything
3a7da8b 
Someone on discord reported issues with UI tests.

This should make sure that git never automatically converts lineendings
for text files to `CRLF`. They should always be `LF` now.

Probably this means that we can stop using dos2unix for rust-lang#3306, too.

Taken from [Rust's .gitattributes file](https://github.com/rust-lang/rust/blob/master/.gitattributes).
@phansch phansch mentioned this issue Dec 2, 2018
Merged
@phansch phansch changed the title Travis Windows: All UI tests are failing Travis Windows: Secret ENV vars break the build Dec 2, 2018
@phansch phansch added the S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work label Dec 2, 2018
@phansch phansch mentioned this issue Dec 2, 2018
Merged
@phansch phansch mentioned this issue Dec 9, 2018
Merged
@phansch
Copy link
Member Author

phansch commented Dec 11, 2018

Maybe adding YARN_GPG=no fixes the problem, too: https://travis-ci.community/t/build-doesnt-finish-after-completing-tests/288/8

bors added a commit that referenced this issue Dec 25, 2018
@bors
Auto merge of #3418 - phansch:add_travis_windows_build, r=<try>
ac8868e 
Fix Travis Windows build

Closes #3306
@phansch
Copy link
Member Author

phansch commented Apr 16, 2019

This particular issue seems to be fixed now and the build continues further

@phansch phansch closed this as completed Apr 16, 2019
bors added a commit that referenced this issue Jul 12, 2019
@bors
Auto merge of #3418 - phansch:add_travis_windows_build, r=<try>
ea12fb0 
Fix Travis Windows build

Closes #3306
bors added a commit that referenced this issue Jul 13, 2019
@bors
Auto merge of #3418 - phansch:add_travis_windows_build, r=<try>
ebfc081 
Fix Travis Windows build

Closes #3306
bors added a commit that referenced this issue Jul 14, 2019
@bors
Auto merge of #3418 - phansch:add_travis_windows_build, r=<try>
25b51f8 
Fix Travis Windows build

Closes #3306
bors added a commit that referenced this issue Jul 14, 2019
@bors
Auto merge of #3418 - phansch:add_travis_windows_build, r=<try>
2655637 
Fix Travis Windows build

Closes #3306
bors added a commit that referenced this issue Jul 15, 2019
@bors
Auto merge of #3418 - phansch:add_travis_windows_build, r=me,flip1995
48b50e8 
Fix Travis Windows build

Closes #3306
@flip1995 flip1995 mentioned this issue Sep 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: Clippy is not doing the correct thing S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Travis Windows build phansch/rust-clippy
2 participants
@mati865 @phansch