Remove --edition from src/crates/using_lib.md #1635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's already past 2021, we might as well presume that a newcomer won't be using an older version to learn instead of updating this parameter once every 3 years.
|
r? @marioidival (rust-highfive has picked a reviewer for you, use r? to override) |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Nov 9, 2022
Update books ## nomicon 1 commits in 9c73283775466d22208a0b28afcab44db4c0cc10..05532356e7a4dbea2330aabb77611f5179493bb8 2022-09-30 07:31:22 +0900 to 2022-11-05 08:13:14 +0900 - Fix typos and grammatical errors (rust-lang/nomicon#384) ## reference 1 commits in 4ea7c5def38ac81df33a9e48e5637a82a5ac404d..9f0cc13ffcd27c1fbe1ab766a9491e15ddcf4d19 2022-10-25 15:14:36 -0700 to 2022-10-31 04:09:16 -0700 - Add a comma (rust-lang/reference#1289) ## book 12 commits in aa5ee485bd6bd80d205da7c82fcdd776f92fdd51..3f64052c048c6def93b94a2b514ee88bba918744 2022-10-20 16:49:55 -0400 to 2022-11-03 22:13:58 -0400 - Upgrade to Rust 1.65 - Upgrade to Rust 1.64 - Upgrade to Rust 1.63 - New ideas for the issue template to try - Clarify that the conditional expression is the one under discussion - Updates from copyedit of ch6 - Made Option<T> error explanation more clear - Update ch06-01-defining-an-enum - Upgrade mdbook - Clarify that user1 can't be used as a whole instance. Fixes rust-lang/book#2978. - Fix plural and incorrect phrase. Fixes rust-lang/book#3359. - Updates from copyedit of ch5 ## rust-by-example 4 commits in 03491f33375c5a2a1661c7fa4be671fe95ce1249..2b15c0abf2bada6e00553814336bc3e2d8399097 2022-10-21 07:30:08 -0300 to 2022-10-31 08:30:13 -0300 - Remove --edition from src/crates/using_lib.md (rust-lang/rust-by-example#1635) - upgrade upload-artifact - Clarify Fn in fn/closures/input_parameters.md (rust-lang/rust-by-example#1634) - fix: erroneous white spaces in types/cast.md ## rustc-dev-guide 12 commits in 51a37ad..d0dc6c9 2022-10-25 10:18:58 -0700 to 2022-11-07 16:49:22 +0200 - trans -> codegen - Remove implementation details - Update some more things and improve wording - Update query.md - replace tabs with spaces (rust-lang/rustc-dev-guide#1504) - align code blocks with their paragraphs - Fixes some typos (rust-lang/rustc-dev-guide#1502) - UPDATE - mention of Diagnostic derive on enums - trans -> codegen (rust-lang/rustc-dev-guide#1500) - add note for err annotation formatting - Remove `--bless` from pre-push hook suggestion - Update for highfive transition.
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Nov 9, 2022
Update books ## nomicon 1 commits in 9c73283775466d22208a0b28afcab44db4c0cc10..05532356e7a4dbea2330aabb77611f5179493bb8 2022-09-30 07:31:22 +0900 to 2022-11-05 08:13:14 +0900 - Fix typos and grammatical errors (rust-lang/nomicon#384) ## reference 1 commits in 4ea7c5def38ac81df33a9e48e5637a82a5ac404d..9f0cc13ffcd27c1fbe1ab766a9491e15ddcf4d19 2022-10-25 15:14:36 -0700 to 2022-10-31 04:09:16 -0700 - Add a comma (rust-lang/reference#1289) ## book 12 commits in aa5ee485bd6bd80d205da7c82fcdd776f92fdd51..3f64052c048c6def93b94a2b514ee88bba918744 2022-10-20 16:49:55 -0400 to 2022-11-03 22:13:58 -0400 - Upgrade to Rust 1.65 - Upgrade to Rust 1.64 - Upgrade to Rust 1.63 - New ideas for the issue template to try - Clarify that the conditional expression is the one under discussion - Updates from copyedit of ch6 - Made Option<T> error explanation more clear - Update ch06-01-defining-an-enum - Upgrade mdbook - Clarify that user1 can't be used as a whole instance. Fixes rust-lang/book#2978. - Fix plural and incorrect phrase. Fixes rust-lang/book#3359. - Updates from copyedit of ch5 ## rust-by-example 4 commits in 03491f33375c5a2a1661c7fa4be671fe95ce1249..2b15c0abf2bada6e00553814336bc3e2d8399097 2022-10-21 07:30:08 -0300 to 2022-10-31 08:30:13 -0300 - Remove --edition from src/crates/using_lib.md (rust-lang/rust-by-example#1635) - upgrade upload-artifact - Clarify Fn in fn/closures/input_parameters.md (rust-lang/rust-by-example#1634) - fix: erroneous white spaces in types/cast.md ## rustc-dev-guide 12 commits in 51a37ad..d0dc6c9 2022-10-25 10:18:58 -0700 to 2022-11-07 16:49:22 +0200 - trans -> codegen - Remove implementation details - Update some more things and improve wording - Update query.md - replace tabs with spaces (rust-lang/rustc-dev-guide#1504) - align code blocks with their paragraphs - Fixes some typos (rust-lang/rustc-dev-guide#1502) - UPDATE - mention of Diagnostic derive on enums - trans -> codegen (rust-lang/rustc-dev-guide#1500) - add note for err annotation formatting - Remove `--bless` from pre-push hook suggestion - Update for highfive transition.
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Nov 9, 2022
Update books ## nomicon 1 commits in 9c73283775466d22208a0b28afcab44db4c0cc10..05532356e7a4dbea2330aabb77611f5179493bb8 2022-09-30 07:31:22 +0900 to 2022-11-05 08:13:14 +0900 - Fix typos and grammatical errors (rust-lang/nomicon#384) ## reference 1 commits in 4ea7c5def38ac81df33a9e48e5637a82a5ac404d..9f0cc13ffcd27c1fbe1ab766a9491e15ddcf4d19 2022-10-25 15:14:36 -0700 to 2022-10-31 04:09:16 -0700 - Add a comma (rust-lang/reference#1289) ## book 12 commits in aa5ee485bd6bd80d205da7c82fcdd776f92fdd51..3f64052c048c6def93b94a2b514ee88bba918744 2022-10-20 16:49:55 -0400 to 2022-11-03 22:13:58 -0400 - Upgrade to Rust 1.65 - Upgrade to Rust 1.64 - Upgrade to Rust 1.63 - New ideas for the issue template to try - Clarify that the conditional expression is the one under discussion - Updates from copyedit of ch6 - Made Option<T> error explanation more clear - Update ch06-01-defining-an-enum - Upgrade mdbook - Clarify that user1 can't be used as a whole instance. Fixes rust-lang/book#2978. - Fix plural and incorrect phrase. Fixes rust-lang/book#3359. - Updates from copyedit of ch5 ## rust-by-example 4 commits in 03491f33375c5a2a1661c7fa4be671fe95ce1249..2b15c0abf2bada6e00553814336bc3e2d8399097 2022-10-21 07:30:08 -0300 to 2022-10-31 08:30:13 -0300 - Remove --edition from src/crates/using_lib.md (rust-lang/rust-by-example#1635) - upgrade upload-artifact - Clarify Fn in fn/closures/input_parameters.md (rust-lang/rust-by-example#1634) - fix: erroneous white spaces in types/cast.md ## rustc-dev-guide 12 commits in 51a37ad..d0dc6c9 2022-10-25 10:18:58 -0700 to 2022-11-07 16:49:22 +0200 - trans -> codegen - Remove implementation details - Update some more things and improve wording - Update query.md - replace tabs with spaces (rust-lang/rustc-dev-guide#1504) - align code blocks with their paragraphs - Fixes some typos (rust-lang/rustc-dev-guide#1502) - UPDATE - mention of Diagnostic derive on enums - trans -> codegen (rust-lang/rustc-dev-guide#1500) - add note for err annotation formatting - Remove `--bless` from pre-push hook suggestion - Update for highfive transition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's already past 2021, we might as well presume that a newcomer won't be using an older version to learn instead of updating this parameter once every 3 years.