-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional helpers to bitfield data structure #2876
Conversation
01e096b
to
e2678d1
Compare
cdda8d8
to
9099f0c
Compare
e666f7c
to
803d46b
Compare
Hi, thanks for working on this!
Otherwise the code looks good to me, maybe Miguel finds something else. Also cc @nbdd0121, it might be a good idea to let him also take a look. |
Whoops, I saw that bindgen used
Okay I'll change it!
|
I tested it again and it LGTM, thanks! |
This commit addresses the case where a struct containing a bitfield is wrapped in a struct such as UnsafeCell which allows interior mutability. Previously, bitfield accessors only allowed a receiver. This becomes problematic in the case of interior mutability as raw pointer access may be required so as not to violate the aliasing rules in Rust.
f6e2c50
to
170c5f9
Compare
Closes #2674