Adds custom_const_pointer_type and custom_mut_pointer_type options. #2708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These options allow specifying an alternate type to use where pointer types would otherwise be used. This is useful for binding to a WebAssembly guest, as well as for certain kinds of serialization and deserialization. Resolves rust-lang#2023.
tgross35
reviewed
Jan 12, 2024
| @@ -352,4 +352,30 @@ pub(crate) mod ast_ty { | |||
| }) | |||
| .collect() | |||
| } | |||
|
|
|||
| pub(crate) fn to_ptr( | |||
There was a problem hiding this comment.
Can you add a quick doc since ToPtr (which had them) was removed?
emilio
requested changes
Jan 12, 2024
|
☔ The latest upstream changes (presumably b5a6813) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These options allow specifying an alternate type to use where pointer types would otherwise be used. This is useful for binding to a WebAssembly guest, as well as for certain kinds of serialization and deserialization.
Resolves #2023.
r? @emilio