BUG: fix incorrect code generation when a struct ends in a bitfield and --explicit-padding
is used
#2406
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A struct ending in a bitfield will have its trailing padding duplicated when
--explicit-padding
is used. This PR adds a test showing this condition, and performs a small check for whether or not the previous field was a bitfield before emitting trailing padding.Please Consider
I do not know if my fix is a good fix, it is merely a fix. I wrote this at 1AM, and it may contain errors in judgement consistent with the time of night.
Also, I was able to find this bug because we run the
bindgen_test_layout_*
test cases in our CI system, and they successfully flagged the difference in size, so thank you for that!Reproduction
Before this patch, the following header would have incorrect Rust code generated when run with
--explicit-padding
.First, we look at the output from bindgen without the
--explicit-padding
flag:Now, we repeat it with
--explicit-padding
:Notice that the second invocation has an extra padding field.