-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update test expectations #1991
Update test expectations #1991
Conversation
This PR was generated by running `BINDGEN_OVERWRITE_EXPECTED=1 cargo test`
r? @emilio |
(I am very likely doing something wrong, I saw these presubmit failures on #1990 and I figured fixing them in a separate PR is the right thing to do, but I mostly have no clue so beware :) |
What clang version are you using? |
Ahh, I see what's going on here, and I think it's the same that @adetaylor was seeing recently on mac. I think whatever clang you're using is confusing our version detection. Your expectations (like Two fixes, one short term and one long term. Short term fix would be something like #1993. Better fix is figuring out what your clang claims to be and what it really is, and fix the version parsing code. |
Thanks for the pointer! I've uploaded #1996 with the parsing fix. I believe this PR can be closed now. Thank you! |
This PR was generated by running
BINDGEN_OVERWRITE_EXPECTED=1 cargo test