Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test expectations #1991

Closed
wants to merge 1 commit into from
Closed

Conversation

hlopko
Copy link
Contributor

@hlopko hlopko commented Feb 11, 2021

This PR was generated by running BINDGEN_OVERWRITE_EXPECTED=1 cargo test

This PR was generated by running `BINDGEN_OVERWRITE_EXPECTED=1 cargo test`
@highfive
Copy link

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

@hlopko
Copy link
Contributor Author

hlopko commented Feb 11, 2021

r? @emilio

@hlopko
Copy link
Contributor Author

hlopko commented Feb 11, 2021

(I am very likely doing something wrong, I saw these presubmit failures on #1990 and I figured fixing them in a separate PR is the right thing to do, but I mostly have no clue so beware :)

@emilio
Copy link
Contributor

emilio commented Feb 13, 2021

What clang version are you using?

emilio added a commit that referenced this pull request Feb 13, 2021
Should fix the test failures described in #1991 and #1975 on modern Mac.
emilio added a commit that referenced this pull request Feb 13, 2021
Should fix the test failures described in #1991 and #1975 on modern Mac.
@emilio
Copy link
Contributor

emilio commented Feb 13, 2021

Ahh, I see what's going on here, and I think it's the same that @adetaylor was seeing recently on mac. I think whatever clang you're using is confusing our version detection. Your expectations (like tests/expectations/tests/issue-643-inner-struct.rs) are the ones expected on modern libclang (tests/expectations/tests/libclang-9/issue-643-inner-struct.rs), so somehow the clang_version() call in tests/tests is failing to detect a version, and we're guessing "ancient".

Two fixes, one short term and one long term. Short term fix would be something like #1993. Better fix is figuring out what your clang claims to be and what it really is, and fix the version parsing code.

@hlopko
Copy link
Contributor Author

hlopko commented Feb 15, 2021

Thanks for the pointer! I've uploaded #1996 with the parsing fix. I believe this PR can be closed now. Thank you!

@hlopko hlopko closed this Feb 15, 2021
emilio added a commit that referenced this pull request Feb 15, 2021
Should fix the test failures described in #1991 and #1975 on modern Mac.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants