-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tests on AArch64 in CI #1980
Conversation
8f542c4
to
5003615
Compare
05790b8
to
98d179b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some questions, but this is great!
.github/workflows/bindgen.yml
Outdated
BINDGEN_FEATURE_RUNTIME: 0 | ||
BINDGEN_FEATURE_EXTRA_ASSERTS: 0 | ||
BINDGEN_FEATURE_TESTING_ONLY_DOCS: 0 | ||
BINDGEN_NO_DEFAULT_FEATURES: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we somehow not duplicate all the testing setup? If not, can we document why?
For example, the curl
command to install rust seems like it should work with actions-rs/toolchain
instead. If it doesn't, why not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way run-on-arch-action
works is by creating a container and the current directory is mounted as a volume within the container. If I installed Rust with actions-rs/toolchain
, the binaries would not be copied into the container. Does that answer your question?
Instead of using Edit: On second thoughts, you might need the dynamic linker and libraries; which is what either the container or the multiarch packages are for. You could still build outside the container. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, mind squashing? Specially the test / empty commits. Other than that it looks good, thank you,
a16dcdf
to
8cd1689
Compare
Squashed!
This would be an improvement! But I've already spent longer than I planned to on this pull request, so I'm going to leave that for someone else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sensible, thank you!
Uses run-on-arch-action to run tests in CI on a virtualized AArch64 environment. This slows down CI quite a bit, but if it were up to me I'd say it's worth the trade-off, since this could surface some critical issues on a soon-to-be tier 1 platform. Hopefully GitHub will release native integration with AArch64 in the future such that this slowness is temporary.