Support #[repr(packed(N))] on Rust 1.33+ #1485

LegNeato · 2019-01-08T04:23:05Z

Fixes #537.

highfive · 2019-01-08T04:23:08Z

Warning

These commits modify unsafe code. Please review it carefully!

emilio

Looks good! Mind addressing the nit and squashing the commits?

Thank you!

src/codegen/mod.rs

Fixes rust-lang#537.

LegNeato · 2019-01-08T17:53:08Z

Failure is an unrelated Travis issue:

info: syncing channel updates for 'nightly-x86_64-unknown-linux-gnu'
error: could not download file from 'https://static.rust-lang.org/dist/channel-rust-nightly.toml.sha256' to '/home/travis/.rustup/tmp/kuu5buqcvbtflcy6_file'
info: caused by: error during download
info: caused by: [28] Timeout was reached

highfive added the S-awaiting-review label Jan 8, 2019

LegNeato force-pushed the packed branch from 20b2c38 to dd28ccd Compare January 8, 2019 05:29

emilio approved these changes Jan 8, 2019

View reviewed changes

src/codegen/mod.rs Outdated Show resolved Hide resolved

Support #[repr(packed(N))] on Rust 1.33+

3994a9a

Fixes rust-lang#537.

LegNeato force-pushed the packed branch from 20ae8e8 to 3994a9a Compare January 8, 2019 16:57

emilio merged commit 2a01e8d into rust-lang:master Jan 8, 2019

LegNeato deleted the packed branch January 9, 2019 07:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support #[repr(packed(N))] on Rust 1.33+ #1485

Support #[repr(packed(N))] on Rust 1.33+ #1485

LegNeato commented Jan 8, 2019

highfive commented Jan 8, 2019

emilio left a comment

LegNeato commented Jan 8, 2019

Support #[repr(packed(N))] on Rust 1.33+ #1485

Support #[repr(packed(N))] on Rust 1.33+ #1485

Conversation

LegNeato commented Jan 8, 2019

highfive commented Jan 8, 2019

emilio left a comment

Choose a reason for hiding this comment

LegNeato commented Jan 8, 2019