select cpp or c search paths based on clang args #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was having troubling using bindgen on a simple C project that included stddef.h. Initially worked around by manually specify the path for Clang system headers files to bindgen in the builder args. Dug a little deeper and realized that for C projects, bindgen still targets the CPP search paths when finding paths to pass to the driver. I propose looking at the clang args as was already done in a debugging function to determine whether the project is C, or C++, and then selecting the search paths based on that. |
emilio
approved these changes
Jul 27, 2018
| @@ -1633,8 +1637,17 @@ impl Bindings { | |||
| if !has_target_arg { | |||
| // TODO: distinguish C and C++ paths? C++'s should be enough, I | |||
| // guess. | |||
|
I'll merge and remove the todo in a followup. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.