Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bindgen --version does not work (0.71.0 regression) #3039

Closed
xry111 opened this issue Dec 7, 2024 · 1 comment · Fixed by #3040
Closed

bindgen --version does not work (0.71.0 regression) #3039

xry111 opened this issue Dec 7, 2024 · 1 comment · Fixed by #3040

Comments

@xry111
Copy link

xry111 commented Dec 7, 2024 

$ bindgen --version
error: the following required arguments were not provided:
  <HEADER>

Usage: bindgen <FLAGS> <OPTIONS> <HEADER> -- <CLANG_ARGS>...

For more information, try '--help'.

This breaks building Mesa of which the build system checks bindgen rust-version using the command.

It worked fine with 0.70.1, and I don't think it makes too much sense to mandate a header when checking rust-bindgen version. Thus I consider it a bug.
@ojeda
Copy link
Contributor

ojeda commented Dec 7, 2024 •
edited
Loading

Yeah, it has regressed (#3037, #2677 (comment)).

In the Linux kernel, as a workaround, we currently pass a dummy parameter, since this happened in 0.69.0 which we support.

@ojeda ojeda mentioned this issue Dec 7, 2024
Open
28 tasks
heftig added a commit to heftig/rust-bindgen that referenced this issue Dec 7, 2024
@heftig
Unbreak shell completion and --version without header
2e154e7 
This regressed again in rust-lang#2984. Partially revert d75fe27 and
42a86e2 and restore the previous behavior.

Fixes: rust-lang#3037
Fixes: rust-lang#3039
@heftig heftig mentioned this issue Dec 7, 2024
Merged
@rami3l rami3l mentioned this issue Dec 8, 2024
Merged
2 tasks
pvdrz added a commit to heftig/rust-bindgen that referenced this issue Dec 8, 2024
@pvdrz
ci: add regression tests for rust-lang#3037 and rust-lang#3039
bcc54f7
pvdrz added a commit to heftig/rust-bindgen that referenced this issue Dec 8, 2024
@pvdrz
ci: add regression tests for rust-lang#3037 and rust-lang#3039
9a8502f
github-merge-queue bot pushed a commit that referenced this issue Dec 8, 2024
@heftig @pvdrz
Unbreak shell completion and --version without header
d9f049b 
This regressed again in #2984. Partially revert d75fe27 and
42a86e2 and restore the previous behavior.

Fixes: #3037
Fixes: #3039
github-merge-queue bot pushed a commit that referenced this issue Dec 8, 2024
@pvdrz
ci: add regression tests for #3037 and #3039
24045bc
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue Dec 9, 2024
@ojeda @intel-lab-lkp
rust: document bindgen 0.71.0 regression
759a632 
`bindgen` 0.71.0 regressed [1] on the "`--version` requires header"
issue which appared in 0.69.0 first [2] and was fixed in 0.69.1. It has
been fixed again in 0.71.1 [3].

Thus document it so that, when we upgrade the minimum past 0.69.0 in the
future, we do not forget that we cannot remove the workaround until we
arrive at 0.71.1 at least.

Link: rust-lang/rust-bindgen#3039 [1]
Link: rust-lang/rust-bindgen#2677 [2]
Link: https://github.com/rust-lang/rust-bindgen/blob/main/CHANGELOG.md#v0711-2024-12-09 [3]
Signed-off-by: Miguel Ojeda <[email protected]>
ojeda added a commit to Rust-for-Linux/linux that referenced this issue Jan 9, 2025
@ojeda
rust: document bindgen 0.71.0 regression
d75d932 
`bindgen` 0.71.0 regressed [1] on the "`--version` requires header"
issue which appared in 0.69.0 first [2] and was fixed in 0.69.1. It has
been fixed again in 0.71.1 [3].

Thus document it so that, when we upgrade the minimum past 0.69.0 in the
future, we do not forget that we cannot remove the workaround until we
arrive at 0.71.1 at least.

Link: rust-lang/rust-bindgen#3039 [1]
Link: rust-lang/rust-bindgen#2677 [2]
Link: https://github.com/rust-lang/rust-bindgen/blob/main/CHANGELOG.md#v0711-2024-12-09 [3]
Reviewed-by: Fiona Behrens <[email protected]>
Reviewed-by: Alice Ryhl <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Miguel Ojeda <[email protected]>
ojeda added a commit to Rust-for-Linux/linux that referenced this issue Jan 9, 2025
@ojeda
rust: document bindgen 0.71.0 regression
c23d1f7 
`bindgen` 0.71.0 regressed [1] on the "`--version` requires header"
issue which appeared in 0.69.0 first [2] and was fixed in 0.69.1. It
has been fixed again in 0.71.1 [3].

Thus document it so that, when we upgrade the minimum past 0.69.0 in the
future, we do not forget that we cannot remove the workaround until we
arrive at 0.71.1 at least.

Link: rust-lang/rust-bindgen#3039 [1]
Link: rust-lang/rust-bindgen#2677 [2]
Link: https://github.com/rust-lang/rust-bindgen/blob/main/CHANGELOG.md#v0711-2024-12-09 [3]
Reviewed-by: Fiona Behrens <[email protected]>
Reviewed-by: Alice Ryhl <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Miguel Ojeda <[email protected]>
@ojeda ojeda mentioned this issue Jan 17, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unbreak shell completion and --version without header heftig/rust-bindgen
2 participants
@ojeda @xry111