-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch log
crate to tracing
#9906
Conversation
It looks like some test code is still using env-logger. |
I believe this problem is caused by |
The license test is in |
You don't have to remove that crate, you can update the allowed license list. |
Only one last issue left in CI checks.
Maybe we should submit a PR to |
This tokio-rs/tracing#1508 PR will fix the compilation error, but it's a breaking change, and will take a little time to be released. |
Is there a lighter weight alternative to tracing appender? I don't think it makes sense to rust-analyzer to depend on chrono, it shouldn't care which year it is outside. |
@matklad I totally agree with you, I'll find a way to replace tracing appender. |
https://docs.rs/tracing-subscriber/0.2.19/tracing_subscriber/fmt/index.html might be a good candidate, but cc tokio-rs/tracing#1436 |
This time I think it's okay. |
fff8d0f
to
0c5e071
Compare
0c5e071
to
ba0947d
Compare
Thanks! bors r+ changelog internal (first contribution) switch from the |
Fixes #9274
log
crate withtracing
of every crate that depend onlog
.log
record macro withtracing
.LoggerFormatter
make output format be the same as original.