Move hir_ty to Chalk IR #8419
Merged
Move hir_ty to Chalk IR #8419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flodiebold
commented
Apr 8, 2021
crates/hir_ty/src/display.rs
Outdated
| @@ -741,7 +745,7 @@ fn write_bounds_like_dyn_trait( | |||
| if !first { | |||
| write!(f, " + ")?; | |||
| } | |||
| // We assume that the self type is $0 (i.e. the | |||
| // We assume that the self type is (i.e. the | |||
There was a problem hiding this comment.
o_O... I think that may have been the result of applying a code action? if there's a $0 in code, do we just let it get treated as a snippet marker?
There was a problem hiding this comment.
yup, we don't do escaping.
🤔 👿 I wonder if we can bypass the whole issue by using some unicode private range character internaly for $, and do escaping in the to_proto?
flodiebold
force-pushed
the
chalk-ir-move
branch
from
67b26d8 to
001c845
Compare
Now that we're using Chalk's `substitute` which actually knows about lifetimes, the hack doesn't work anymore, but we can put in a proper lifetime.
flodiebold
force-pushed
the
chalk-ir-move
branch
from
001c845 to
8040f4a
Compare
|
changelog internal Type inference now uses Chalk's types everywhere, instead of having its own representations and mapping between them |
lnicola
approved these changes
Apr 8, 2021
|
bors r+ |
|
987 MB -> 1018 MB RAM on self. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8313.
There's some further cleanups to do:
TypeWalkin lots of places (not for mutating/folding though, just for walking)InferenceTableToChalkstill exists and gets called, it's just the identity in most cases now (I'll probably clean those up before merging this)