Unleash inner item resolution to users #7614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jonas-schievink
commented
Feb 9, 2021
jonas-schievink
commented
This required a few changes to not bail out immediately if a `ModuleScope` doesn't resolve a path. The `LocalItemsScope` hack is now removed.
|
This still doesn't work with trait method resolution:
Still, it didn't eat my cat. I'd say we merge it so it can bake in the nightlies and for people who build from source. |
matklad
reviewed
Feb 9, 2021
| let root = self.parse_or_expand(file_id).unwrap(); | ||
| let ast_map = self.ast_id_map(file_id); | ||
| let item_tree = self.item_tree(file_id); | ||
| for decl in module.scope.declarations() { |
There was a problem hiding this comment.
Interesting... It feels like it might hit "accidentally quadratic" someday. We probably shouldn't worry about that now.
|
bors r+ |
This was referenced Feb 10, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.