Introduce HirDisplay method for rendering source code & use it in add_function assist #4175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimoFreiberg
commented
Apr 27, 2020
TimoFreiberg
commented
Apr 27, 2020
TimoFreiberg
commented
Apr 27, 2020
TimoFreiberg
commented
Apr 27, 2020
TimoFreiberg
force-pushed
the
add_function_type_path
branch
from
69041ba to
aa1bfa9
Compare
TimoFreiberg
commented
Apr 27, 2020
flodiebold
reviewed
Apr 28, 2020
TimoFreiberg
force-pushed
the
add_function_type_path
branch
3 times, most recently
from
1a8d3dd to
ff29a1c
Compare
TimoFreiberg
force-pushed
the
add_function_type_path
branch
from
ff29a1c to
64e6b82
Compare
|
@flodiebold do you have more comments here? Changes look good to me! |
|
No, LGTM as well. bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next feature for #3639.
So far the only change in the new
HirDisplaymethod is that paths are qualified, but more changes will be necessary (omitting the function name from function types, returning an error instead of printing"{unknown}", probably more).Is that approach okay?