Use x86_64-unknown-linux-gnu for releases

[lnicola]

The reasoning here is that we don't call much C code, and libstd should already be compatible with older Linux distributions.

Tested by running rust-analyzer analysis-stats on Ubuntu 14.04 with a binary compiled on Arch Linux.

This should make for faster binaries and avoid some problems with musl dlopen() not working (thus breaking procedural macro support).

[bors]

✌️ lnicola can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

[lnicola]

Maybe they've fixed it?

bors r=maklad

[lnicola]

Guess not. @matklad pretty please?

[Veetaha]

@lnicola how should it make for faster binaries?

[lnicola]

rust-analyzer go BRRR

Faster, and more compatible with proc macros. Also possibly more crashy.

[lnicola]

@Veetaha #3459

[lnicola]

Some bad news: our binaries don't work on CentOS 7:

./rust-analyzer: /usr/lib64/libc.so.6: version `GLIBC_2.18' not found (required by ./rust-analyzer)

See rust-lang/rust#57497. CentOS 7 has glibc 2.17. I'm not sure how I feel about this. CentOS has pretty old software (glibc 2.17 is from 2012), but it might be popular in enterprise environments. This will probably be solver when moving to the build infra of the rust-lang project.

[cuviper]

This will probably be solver when moving to the build infra of the rust-lang project.

Are there specific plans for this? You could look at how rustup is borrowing the same images:
https://github.com/rust-lang/rustup/blob/master/ci/fetch-rust-docker.bash
rust-lang/rustup#1724

[ivan]

The new build does not run on any NixOS either (NixOS doesn't have a /lib), but it can be patched:

nix-env -iA patchelf
patchelf --set-interpreter "$(patchelf --print-interpreter /run/current-system/sw/bin/sh)" ~/.vscode-server/data/User/globalStorage/matklad.rust-analyzer/rust-analyzer-linux

[matklad]

@cuviper no, no specific plans -- the current assumption is that for most users the binaries we publish are fine. SO, I don't think it makes sense to make our current CI more complicated to get the long tail. Once we ship via rustup, that should be fixed.

[matklad]

@ivan see also https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/tools/rust/rust-analyzer/default.nix