fix: Resolve included files to their calling modules in IDE layer #17863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
@bors r+ |
Veykril
changed the title
|
☀️ Test successful - checks-actions |
bors
added a commit
that referenced
this pull request
Aug 13, 2024
internal: Remove unreachable logic for include token mapping Turns out #17863 made this obsolete 🎉
bors
added a commit
that referenced
this pull request
Aug 13, 2024
internal: Remove unreachable logic for include token mapping Turns out #17863 made this obsolete 🎉
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Aug 13, 2024
…=Veykril internal: Remove unreachable logic for include token mapping Turns out rust-lang/rust-analyzer#17863 made this obsolete 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17390 at the expense of reporting duplicate diagnostics for modules that have includes in them when both the calling and called file are included.