Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement lifetime inferring #17595

Merged
merged 1 commit into from
Aug 16, 2024
Merged

feat: Implement lifetime inferring #17595

merged 1 commit into from
Aug 16, 2024

Conversation

dfireBird
Copy link
Contributor

No description provided.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 15, 2024
@bors
Copy link
Contributor

bors commented Jul 19, 2024

☔ The latest upstream changes (presumably #17620) made this pull request unmergeable. Please resolve the merge conflicts.

@dfireBird dfireBird force-pushed the infer-lt branch 2 times, most recently from 6006a8e to b9e9e29 Compare July 22, 2024 16:25
@bors
Copy link
Contributor

bors commented Jul 31, 2024

☔ The latest upstream changes (presumably #17755) made this pull request unmergeable. Please resolve the merge conflicts.

@Veykril Veykril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 2, 2024
@dfireBird dfireBird marked this pull request as ready for review August 15, 2024 17:49
@bors
Copy link
Contributor

bors commented Aug 16, 2024

☔ The latest upstream changes (presumably #17907) made this pull request unmergeable. Please resolve the merge conflicts.

@flodiebold
Copy link
Member

@bors r+

thanks!

@bors
Copy link
Contributor

bors commented Aug 16, 2024

📌 Commit 8a4261a has been approved by flodiebold

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Aug 16, 2024

⌛ Testing commit 8a4261a with merge ed5c260...

@bors
Copy link
Contributor

bors commented Aug 16, 2024

☀️ Test successful - checks-actions
Approved by: flodiebold
Pushing ed5c260 to master...

@bors bors merged commit ed5c260 into rust-lang:master Aug 16, 2024
11 checks passed
@lnicola lnicola changed the title Implement lifetime inferring feat: Implement lifetime inferring Aug 16, 2024
@dfireBird dfireBird deleted the infer-lt branch August 16, 2024 15:40
@Veykril
Copy link
Member

Veykril commented Aug 19, 2024

This regressed unknown types from 41 to 62 on self somehow 🤔

@dfireBird
Copy link
Contributor Author

dfireBird commented Aug 19, 2024 •
edited
Loading

There shouldn't be anything creating new TyKind::Error values. I'll check on that. Meanwhile, if you want to revert that commit we can.

@Veykril
Copy link
Member

Veykril commented Aug 20, 2024

It's fine, it only regressed on self so its likely not too bad. I imagine unification fails due to some new lifetimes now within chalk

@dfireBird dfireBird mentioned this pull request Sep 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Veykril Veykril Veykril approved these changes

Assignees
No one assigned
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dfireBird @bors @flodiebold @Veykril @rustbot