internal: refactor prefer_no_std/prefer_prelude bools into a struct
#17252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
This was referenced May 20, 2024
Veykril
force-pushed
the
david/refactor-standalone-bools-into-struct
branch
from
4da6dbf
to
04d9910
Compare
Veykril
force-pushed
the
david/refactor-standalone-bools-into-struct
branch
from
04d9910
to
dc565d4
Compare
|
Rebased it given my PR had a bunch of conflicts touching the same parts :) The new |
bors
added a commit
that referenced
this pull request
May 22, 2024
…to-struct, r=Veykril internal: refactor `prefer_no_std`/`prefer_prelude` bools into a struct I noticed that there's a large number of functions/arguments during an unrelated change that take two booleans and realized they're _probably_ better off being in a single struct—less error-prone, etc. Feel free to suggest a better name than `ImportPathConfig`/close this entirely! I can also make these args enums; just hopefully making this a little more misuse-resistant.
|
💔 Test failed - checks-actions |
Veykril
force-pushed
the
david/refactor-standalone-bools-into-struct
branch
from
dc565d4
to
3eb607c
Compare
|
small rebase mishap |
bors
added a commit
that referenced
this pull request
May 22, 2024
…to-struct, r=Veykril internal: refactor `prefer_no_std`/`prefer_prelude` bools into a struct I noticed that there's a large number of functions/arguments during an unrelated change that take two booleans and realized they're _probably_ better off being in a single struct—less error-prone, etc. Feel free to suggest a better name than `ImportPathConfig`/close this entirely! I can also make these args enums; just hopefully making this a little more misuse-resistant.
|
💔 Test failed - checks-actions |
Veykril
force-pushed
the
david/refactor-standalone-bools-into-struct
branch
from
3eb607c
to
3a7dcf9
Compare
|
@bors r+ |
|
☀️ Test successful - checks-actions |
This was referenced May 28, 2024
This was referenced Jun 1, 2024
This was referenced Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that there's a large number of functions/arguments during an unrelated change that take two booleans and realized they're probably better off being in a single struct—less error-prone, etc.
Feel free to suggest a better name than
ImportPathConfig/close this entirely! I can also make these args enums; just hopefully making this a little more misuse-resistant.