feat: add generate_mut_trait_impl assist #15832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
lnicola
reviewed
Nov 4, 2023
|
r? @alibektas |
alibektas
suggested changes
Nov 4, 2023
Young-Flash
force-pushed
the
generate_mut_trait
branch
from
f79e2c4 to
b84940b
Compare
lnicola
approved these changes
Nov 5, 2023
|
@bors r+ Thanks, Young-Flash and alibektas! |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate proper
index_mutmethod body refer toindexmethod body may impossible due to the unpredicable case (#15581).Here just leave the
index_mutmethod body be same asindexmethod body, user can modify it manually to meet their need.