Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete enum variants without parens when snippets are disabled #13805

Merged
merged 2 commits into from
Dec 20, 2022

Conversation

ntBre
Copy link
Contributor

@ntBre ntBre commented Dec 20, 2022

This handles the portion of #13767 that bothered me, but I can try to work on the other parts we discussed if needed.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 20, 2022
@jonas-schievink
Copy link
Contributor

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Dec 20, 2022

📌 Commit 694ae77 has been approved by jonas-schievink

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Dec 20, 2022

⌛ Testing commit 694ae77 with merge 5c8f00f...

@bors
Copy link
Contributor

bors commented Dec 20, 2022

☀️ Test successful - checks-actions
Approved by: jonas-schievink
Pushing 5c8f00f to master...

@bors bors merged commit 5c8f00f into rust-lang:master Dec 20, 2022
ntBre added a commit to ntBre/rust-analyzer that referenced this pull request Jan 4, 2023
this is the record literal version of rust-lang#13805, which handled the same issue for
tuple literals
bors added a commit that referenced this pull request Jan 4, 2023
Complete record enum variants without parens when snippets are disabled

I didn't realize I only handled this for tuple variants in #13805. This is the same change but for record variants.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants