Properly handle break resolution inside non-breakable expressions #13165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r+ |
bors
added a commit
that referenced
this pull request
Sep 1, 2022
Properly handle break resolution inside non-breakable expressions We now diagnose invalid `continue` expressions and properly handle things like `async` blocks which prevent labels from resolving further. Cleaned this up since `label_break_value` is on the way to stabilization in rust (🎉 finally) and we weren't handling breaks for blocks properly yet.
|
💔 Test failed - checks-actions |
|
@bors r+ |
|
☀️ Test successful - checks-actions |
|
Damn, that's a bad warning. IIRC, that flag is set in rust-lang/rust, at least for some of the code. |
|
It's an odd warning, why is that even triggering in 2021 crates with that ... I hope rust-lang won't complain here ... |
|
Yeah, rust-lang/rust#101284. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now diagnose invalid
continueexpressions and properly handle things likeasyncblocks which prevent labels from resolving further. Cleaned this up sincelabel_break_valueis on the way to stabilization in rust (🎉 finally) and we weren't handling breaks for blocks properly yet.