Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: extend MissingOkInTailExpr diagnostic to also do Some-wrapping for Options. #7095

Closed
theotherphil opened this issue Dec 30, 2020 · 0 comments · Fixed by #7097
Closed

Feature: extend MissingOkInTailExpr diagnostic to also do Some-wrapping for Options. #7095

theotherphil opened this issue Dec 30, 2020 · 0 comments · Fixed by #7097

Comments

@theotherphil
Copy link
Contributor

theotherphil commented Dec 30, 2020 •
edited
Loading

I'll take this one.
@theotherphil theotherphil mentioned this issue Dec 30, 2020
Merged
bors bot added a commit that referenced this issue Jan 7, 2021
@bors @theotherphil @matklad
Merge #7097 #7199
9d6a915 
7097: Add fix to wrap return expression in Some r=matklad a=theotherphil

Fixes #7095

7199: typo r=matklad a=matklad

bors r+
🤖

Co-authored-by: Phil Ellison <[email protected]>
Co-authored-by: Aleksey Kladov <[email protected]>
bors bot added a commit that referenced this issue Jan 7, 2021
@bors @theotherphil
Merge #7097
2d389bd 
7097: Add fix to wrap return expression in Some r=matklad a=theotherphil

Fixes #7095

Co-authored-by: Phil Ellison <[email protected]>
@bors bors bot closed this as completed in 5722d2b Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add fix to wrap return expression in Some theotherphil/rust-analyzer
1 participant
@theotherphil